* [PATCH] mt76x2: fix is_mt7612 routine
@ 2018-04-17 22:27 Lorenzo Bianconi
2018-04-18 10:18 ` Felix Fietkau
2018-04-30 10:21 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2018-04-17 22:27 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless
Fix is_mt7612 routine since asic version is set in mt76_dev revision
field and not in mt76x2_dev one.
Moreover remove mt76x2_dev rev field since it is never used in the
driver
Fixes: 7bc04215a66b ('mt76: add driver code for MT76x2e')
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x2.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2.h b/drivers/net/wireless/mediatek/mt76/mt76x2.h
index 783b8122ec3c..a5d1255e4b9c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2.h
@@ -117,7 +117,6 @@ struct mt76x2_dev {
u8 beacon_mask;
u8 beacon_data_mask;
- u32 rev;
u32 rxfilter;
u16 chainmask;
@@ -151,7 +150,7 @@ struct mt76x2_sta {
static inline bool is_mt7612(struct mt76x2_dev *dev)
{
- return (dev->rev >> 16) == 0x7612;
+ return mt76_chip(&dev->mt76) == 0x7612;
}
void mt76x2_set_irq_mask(struct mt76x2_dev *dev, u32 clear, u32 set);
--
2.16.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76x2: fix is_mt7612 routine
2018-04-17 22:27 [PATCH] mt76x2: fix is_mt7612 routine Lorenzo Bianconi
@ 2018-04-18 10:18 ` Felix Fietkau
2018-04-30 10:21 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2018-04-18 10:18 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless
On 2018-04-18 00:27, Lorenzo Bianconi wrote:
> Fix is_mt7612 routine since asic version is set in mt76_dev revision
> field and not in mt76x2_dev one.
> Moreover remove mt76x2_dev rev field since it is never used in the
> driver
>
> Fixes: 7bc04215a66b ('mt76: add driver code for MT76x2e')
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mt76x2: fix is_mt7612 routine
2018-04-17 22:27 [PATCH] mt76x2: fix is_mt7612 routine Lorenzo Bianconi
2018-04-18 10:18 ` Felix Fietkau
@ 2018-04-30 10:21 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-04-30 10:21 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> Fix is_mt7612 routine since asic version is set in mt76_dev revision
> field and not in mt76x2_dev one.
> Moreover remove mt76x2_dev rev field since it is never used in the
> driver
>
> Fixes: 7bc04215a66b ('mt76: add driver code for MT76x2e')
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers-next.git, thanks.
97389373d555 mt76x2: fix is_mt7612 routine
--
https://patchwork.kernel.org/patch/10346967/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-30 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-17 22:27 [PATCH] mt76x2: fix is_mt7612 routine Lorenzo Bianconi
2018-04-18 10:18 ` Felix Fietkau
2018-04-30 10:21 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).