From: Kalle Valo <kvalo@codeaurora.org>
To: Eyal Reizer <eyalreizer@gmail.com>
Cc: linux-wireless@vger.kernel.org, robh@kernel.org, sre@kernel.org,
tony@atomide.com, linux-kernel@vger.kernel.org,
Eyal Reizer <eyalr@ti.com>
Subject: Re: [v2] wlcore: sdio: allow pm to handle sdio power
Date: Mon, 30 Apr 2018 10:31:27 +0000 (UTC) [thread overview]
Message-ID: <20180430103127.274E86079C@smtp.codeaurora.org> (raw)
In-Reply-To: <1524721631-5983-1-git-send-email-eyalr@ti.com>
Eyal Reizer <eyalreizer@gmail.com> wrote:
> pm_runtime handles sdio power on and power off transitions.
> An old workaround for trying to control the power explicitly from the
> driver was in fact causing failures on suspend/resume as the mmc layer
> already power the module on resume.
>
> In case of resume pm_runtime_get sync returns a positive device's usage
> count causing the driver to try an re-initialize an already initialized
> device. This was causing sdio bus failure on resume.
>
> Remove this manual power on/off sequence as it is in-fact not needed.
>
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> Acked-by: Tony Lindgren <tony@atomide.com>
Patch applied to wireless-drivers-next.git, thanks.
60f36637bbbd wlcore: sdio: allow pm to handle sdio power
--
https://patchwork.kernel.org/patch/10364645/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-04-30 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 5:47 [PATCH v2] wlcore: sdio: allow pm to handle sdio power Eyal Reizer
2018-04-26 8:16 ` Kalle Valo
2018-04-26 8:37 ` [EXTERNAL] " Reizer, Eyal
2018-04-26 9:26 ` Kalle Valo
2018-04-26 10:14 ` Reizer, Eyal
2018-04-30 10:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430103127.274E86079C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).