From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38248 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbeD3KdP (ORCPT ); Mon, 30 Apr 2018 06:33:15 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: rsi_91x: fix structurally dead code From: Kalle Valo In-Reply-To: <20180426130138.GA440@embeddedor.com> References: <20180426130138.GA440@embeddedor.com> To: "Gustavo A. R. Silva" Cc: Prameela Rani Garnepudi , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Message-Id: <20180430103315.35F26606AC@smtp.codeaurora.org> (sfid-20180430_123334_408009_57209BF2) Date: Mon, 30 Apr 2018 10:33:15 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: "Gustavo A. R. Silva" wrote: > Function rsi_hal_key_config returns before reaching code at line > 922 if (status), hence this code is structurally dead. > > Fix this by storing the value returned by rsi_hal_load_key > into _status_ for its further evaluation and use. > > Addresses-Coverity-ID: 1468409 ("Structurally dead code") > Fixes: 4fd6c4762f37 ("rsi: roaming enhancements") > Signed-off-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. e1fd7ceec194 rsi_91x: fix structurally dead code -- https://patchwork.kernel.org/patch/10365997/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches