From: Tony Lindgren <tony@atomide.com>
To: "Reizer, Eyal" <eyalr@ti.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
KISHON VIJAY ABRAHAM <kishon@ti.com>, "Mishol, Guy" <guym@ti.com>,
Luca Coelho <luciano.coelho@intel.com>,
"Hahn, Maital" <maitalm@ti.com>,
"Altshul, Maxim" <maxim.altshul@ti.com>,
Shahar Patury <shaharp@ti.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Loewy, Chen" <c-loewy@ti.com>
Subject: Re: [EXTERNAL] [PATCHv2 0/5] Runtime PM support for wlcore
Date: Mon, 21 May 2018 09:38:30 -0700 [thread overview]
Message-ID: <20180521163830.GZ98604@atomide.com> (raw)
In-Reply-To: <bff51dcc6fd441d9ab42db273219aaf4@ti.com>
* Reizer, Eyal <eyalr@ti.com> [180521 07:31]:
> > Here's a series of patches to add runtime PM support for wlcore. It does not
> > yet implement autosuspend support, but let's get this tested first as the
> > autosuspend can mask enable/disable issues easily.
>
> Testing on BBB+WL1837 cape, scan, recovery, down/up and basic traffic seems ok now.
> Of course we need to test some more.
Thanks for testing. Yes let's do more testing, no rush with these.
Hopefully they'll be ready for v4.19 merge window though.
> Standard suspend/resume seems to work ok as well.
> Ennabling wowlan and suspending is crashing on resume. See below.
>
> root@am335x-evm:/usr/share/wl18xx# iw phy0 wowlan enable any dme
> root@am335x-evm:/usr/share/wl18xx#
> root@am335x-evm:/usr/share/wl18xx# echo mem > /sys/power/state
> [ 541.567039] PM: suspend entry (deep)
> [ 541.570688] PM: Syncing filesystems ... done.
> [ 541.594277] Freezing user space processes ... (elapsed 0.001 seconds) done.
> [ 541.603160] OOM killer disabled.
> [ 541.606738] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
> [ 541.615984] Suspending console(s) (use no_console_suspend to debug)
> [ 542.895091] pm33xx pm33xx: PM: Successfully put all powerdomains to target state
> [ 542.895091] PM: Wakeup source UART
> [ 542.919791] net eth0: initializing cpsw version 1.12 (0)
> [ 543.017880] SMSC LAN8710/LAN8720 4a101000.mdio:00: attached PHY driver [SMSC LAN8710/LAN8720] (mii_bus:phy_addr=4a101000.mdio:00, irq=POLL)
> [ 543.027646] ------------[ cut here ]------------
> [ 543.028023] WARNING: CPU: 0 PID: 932 at drivers/net/wireless/ti/wlcore/cmd.c:76 wlcore_cmd_send_failsafe+0x498/0x4f8 [wlcore]
This warning is because wlcore is wlcore is still in ELP. This is
somehow possible even though we call pm_runtime_get_sync() in
wl1271_op_resume(). Anyways, I'll try to reproduce it here.
Regards,
Tony
next prev parent reply other threads:[~2018-05-21 16:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 18:50 [PATCHv2 0/5] Runtime PM support for wlcore Tony Lindgren
2018-05-17 18:50 ` [PATCH 1/5] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout() Tony Lindgren
2018-05-17 18:50 ` [PATCH 2/5] wlcore: Make sure PM calls are paired Tony Lindgren
2018-05-17 18:50 ` [PATCH 3/5] wlcore: Add support for runtime PM Tony Lindgren
2018-05-17 18:50 ` [PATCH 4/5] wlcore: Fix misplaced PM call for scan_complete_work() Tony Lindgren
2018-05-17 18:50 ` [PATCH 5/5] wlcore: sdio: Warn about runtime PM suspend errors Tony Lindgren
2018-05-21 22:32 ` Tony Lindgren
2018-05-17 18:59 ` [PATCHv2 0/5] Runtime PM support for wlcore Tony Lindgren
2018-05-21 7:29 ` [EXTERNAL] " Reizer, Eyal
2018-05-21 16:38 ` Tony Lindgren [this message]
2018-05-21 22:43 ` Tony Lindgren
2018-05-22 6:40 ` Reizer, Eyal
2018-05-22 13:50 ` Tony Lindgren
2018-05-22 13:26 ` Reizer, Eyal
2018-05-22 13:31 ` Tony Lindgren
2018-05-22 13:48 ` Reizer, Eyal
2018-05-22 13:55 ` Tony Lindgren
2018-05-22 14:05 ` Reizer, Eyal
2018-05-22 15:01 ` Tony Lindgren
2018-05-22 17:23 ` Tony Lindgren
2018-05-23 7:04 ` Reizer, Eyal
2018-05-22 8:02 ` Kalle Valo
2018-05-22 13:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521163830.GZ98604@atomide.com \
--to=tony@atomide.com \
--cc=c-loewy@ti.com \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=kishon@ti.com \
--cc=kvalo@codeaurora.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=maitalm@ti.com \
--cc=maxim.altshul@ti.com \
--cc=shaharp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).