From: Kalle Valo <kvalo@codeaurora.org>
To: Ganapathi Bhat <gbhat@marvell.com>
Cc: <linux-wireless@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Cathy Luo <cluo@marvell.com>, Xinming Hu <huxm@marvell.com>,
Zhiyuan Yang <yangzy@marvell.com>, James Cao <jcao@marvell.com>,
Mangesh Malusare <mmangesh@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>
Subject: Re: mwifiex: handle race during mwifiex_usb_disconnect
Date: Tue, 29 May 2018 07:23:14 +0000 (UTC) [thread overview]
Message-ID: <20180529072314.84BDD6060A@smtp.codeaurora.org> (raw)
In-Reply-To: <1527169707-27317-1-git-send-email-gbhat@marvell.com>
Ganapathi Bhat <gbhat@marvell.com> wrote:
> Race condition is observed during rmmod of mwifiex_usb:
>
> 1. The rmmod thread will call mwifiex_usb_disconnect(), download
> SHUTDOWN command and do wait_event_interruptible_timeout(),
> waiting for response.
>
> 2. The main thread will handle the response and will do a
> wake_up_interruptible(), unblocking rmmod thread.
>
> 3. On getting unblocked, rmmod thread will make rx_cmd.urb = NULL in
> mwifiex_usb_free().
>
> 4. The main thread will try to resubmit rx_cmd.urb in
> mwifiex_usb_submit_rx_urb(), which is NULL.
>
> To fix, wait for main thread to complete before calling
> mwifiex_usb_free().
>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
b817047ae70c mwifiex: handle race during mwifiex_usb_disconnect
--
https://patchwork.kernel.org/patch/10424763/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-05-29 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 13:48 [PATCH] mwifiex: handle race during mwifiex_usb_disconnect Ganapathi Bhat
2018-05-29 7:23 ` Kalle Valo [this message]
2018-05-29 21:59 ` Brian Norris
2018-05-30 7:20 ` [EXT] " Ganapathi Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529072314.84BDD6060A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmangesh@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).