From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luca@coelho.fi>
Cc: emmanuel.grumbach@intel.com, jadit2@gmail.com,
linux-wireless@vger.kernel.org, Hao Wei Tee <angelsl@in04.sg>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: iwlwifi: pcie: compare with number of IRQs requested for, not number of CPUs
Date: Tue, 29 May 2018 07:40:50 +0000 (UTC) [thread overview]
Message-ID: <20180529074050.2ECF360591@smtp.codeaurora.org> (raw)
In-Reply-To: <20180529072517.30135-1-luca@coelho.fi>
Luciano Coelho <luca@coelho.fi> wrote:
> From: Hao Wei Tee <angelsl@in04.sg>
>
> When there are 16 or more logical CPUs, we request for
> `IWL_MAX_RX_HW_QUEUES` (16) IRQs only as we limit to that number of
> IRQs, but later on we compare the number of IRQs returned to
> nr_online_cpus+2 instead of max_irqs, the latter being what we
> actually asked for. This ends up setting num_rx_queues to 17 which
> causes lots of out-of-bounds array accesses later on.
>
> Compare to max_irqs instead, and also add an assertion in case
> num_rx_queues > IWM_MAX_RX_HW_QUEUES.
>
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=199551
>
> Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration to enable MSIX")
> Signed-off-by: Hao Wei Tee <angelsl@in04.sg>
> Tested-by: Sara Sharon <sara.sharon@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers.git, thanks.
ab1068d6866e iwlwifi: pcie: compare with number of IRQs requested for, not number of CPUs
--
https://patchwork.kernel.org/patch/10434495/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-05-29 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 7:25 [PATCH] iwlwifi: pcie: compare with number of IRQs requested for, not number of CPUs Luca Coelho
2018-05-29 7:31 ` Kalle Valo
[not found] ` <CADPGViGBfviaasvCLQWTXo4=R2Fx2BLfpm7b0Ws=aH0oKw9ckg@mail.gmail.com>
2018-05-29 14:50 ` Luca Coelho
2018-05-29 7:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529074050.2ECF360591@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=angelsl@in04.sg \
--cc=emmanuel.grumbach@intel.com \
--cc=jadit2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).