From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: linux-wireless@vger.kernel.org
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Andrey Shevchenko <ashevchenko@quantenna.com>,
Sergei Maksimenko <smaksimenko@quantenna.com>
Subject: [PATCH 1/6] qtnfmac: implement net_device_ops callback to set MAC address
Date: Thu, 31 May 2018 12:10:57 +0300 [thread overview]
Message-ID: <20180531091102.28666-2-sergey.matyukevich.os@quantenna.com> (raw)
In-Reply-To: <20180531091102.28666-1-sergey.matyukevich.os@quantenna.com>
From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Implement net_device_ops::ndo_set_mac_address callback to allow for
setting interface MAC address. Implementation is done through existing
CHANGE_INTF firmware command. All validation is to be done by firmware.
Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
---
drivers/net/wireless/quantenna/qtnfmac/core.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c
index a6a450984f9a..c318340e1bd5 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/core.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/core.c
@@ -179,6 +179,30 @@ static void qtnf_netdev_tx_timeout(struct net_device *ndev)
}
}
+static int qtnf_netdev_set_mac_address(struct net_device *ndev, void *addr)
+{
+ struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
+ struct sockaddr *sa = addr;
+ int ret;
+ unsigned char old_addr[ETH_ALEN];
+
+ memcpy(old_addr, sa->sa_data, sizeof(old_addr));
+
+ ret = eth_mac_addr(ndev, sa);
+ if (ret)
+ return ret;
+
+ qtnf_scan_done(vif->mac, true);
+
+ ret = qtnf_cmd_send_change_intf_type(vif, vif->wdev.iftype,
+ sa->sa_data);
+
+ if (ret)
+ memcpy(ndev->dev_addr, old_addr, ETH_ALEN);
+
+ return ret;
+}
+
/* Network device ops handlers */
const struct net_device_ops qtnf_netdev_ops = {
.ndo_open = qtnf_netdev_open,
@@ -186,6 +210,7 @@ const struct net_device_ops qtnf_netdev_ops = {
.ndo_start_xmit = qtnf_netdev_hard_start_xmit,
.ndo_tx_timeout = qtnf_netdev_tx_timeout,
.ndo_get_stats64 = qtnf_netdev_get_stats64,
+ .ndo_set_mac_address = qtnf_netdev_set_mac_address,
};
static int qtnf_mac_init_single_band(struct wiphy *wiphy,
--
2.11.0
next prev parent reply other threads:[~2018-05-31 9:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 9:10 [PATCH 0/6] qtnfmac: enable more features Sergey Matyukevich
2018-05-31 9:10 ` Sergey Matyukevich [this message]
2018-06-27 15:54 ` [1/6] qtnfmac: implement net_device_ops callback to set MAC address Kalle Valo
[not found] ` <20180627155439.481E76034E@smtp.codeaurora.org>
2018-06-29 9:26 ` Sergey Matyukevich
2018-06-29 9:43 ` Kalle Valo
2018-06-29 12:03 ` Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 2/6] qtnfmac: enable source MAC address randomization support Sergey Matyukevich
2018-05-31 9:10 ` [PATCH 3/6] qtnfmac: implement cfg80211 power management callback Sergey Matyukevich
2018-06-01 1:04 ` Igor Mitsyanko
2018-06-04 12:50 ` Sergey Matyukevich
2018-06-04 18:58 ` Igor Mitsyanko
2018-07-30 13:55 ` Kalle Valo
2018-07-30 14:12 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 4/6] qtnfmac: enable multiple SSIDs scan support Sergey Matyukevich
2018-05-31 9:11 ` [PATCH 5/6] qtnfmac: add support for PTA configuration Sergey Matyukevich
2018-07-30 14:06 ` Kalle Valo
2018-07-31 11:42 ` Arend van Spriel
2018-08-01 8:23 ` Sergey Matyukevich
2018-08-04 22:19 ` Arend van Spriel
2018-08-05 15:22 ` Sergey Matyukevich
2018-08-05 21:34 ` Arend van Spriel
2018-08-01 8:25 ` Kalle Valo
2018-05-31 9:11 ` [PATCH 6/6] qtnfmac: implement basic WoWLAN support Sergey Matyukevich
2018-07-30 14:13 ` Kalle Valo
2018-07-31 9:59 ` Sergey Matyukevich
2018-08-01 8:38 ` Kalle Valo
2018-05-31 9:36 ` [PATCH 0/6] qtnfmac: enable more features Kalle Valo
2018-05-31 10:35 ` Sergey Matyukevich
2018-05-31 11:12 ` Kalle Valo
2018-06-01 1:08 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531091102.28666-2-sergey.matyukevich.os@quantenna.com \
--to=sergey.matyukevich.os@quantenna.com \
--cc=ashevchenko@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=smaksimenko@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).