[PATCH net-next] ath10k: make some functions static

[PATCH net-next] ath10k: make some functions static

[Wei Yongjun]

Fixes the following sparse warnings:

drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
 symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
 symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/wireless/ath/ath10k/snoc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index 47a4d2a..c82bc6f 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -820,7 +820,7 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar)
 	.write32	= ath10k_snoc_write32,
 };
 
-int ath10k_snoc_get_ce_id_from_irq(struct ath10k *ar, int irq)
+static int ath10k_snoc_get_ce_id_from_irq(struct ath10k *ar, int irq)
 {
 	struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar);
 	int i;
@@ -868,7 +868,7 @@ static int ath10k_snoc_napi_poll(struct napi_struct *ctx, int budget)
 	return done;
 }
 
-void ath10k_snoc_init_napi(struct ath10k *ar)
+static void ath10k_snoc_init_napi(struct ath10k *ar)
 {
 	netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_snoc_napi_poll,
 		       ATH10K_NAPI_BUDGET);

Re: [PATCH net-next] ath10k: make some functions static

[Kalle Valo]

Wei Yongjun <weiyongjun1@huawei.com> writes:

> Fixes the following sparse warnings:
>
> drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
> drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

BTW this goes to my ath.git tree, not to net-next.

I had missed these as I can't enable ATH10K_SNOC on x86 and hence I
don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve
that? IIRC we had a similar problem with wcn36xx but I don't remember
anymore how it was fixed.

-- 
Kalle Valo

Re: [PATCH net-next] ath10k: make some functions static

[Niklas Cassel]

On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote:
> Wei Yongjun <weiyongjun1@huawei.com> writes:
> 
> > Fixes the following sparse warnings:
> >
> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
> >  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
> >  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> BTW this goes to my ath.git tree, not to net-next.
> 
> I had missed these as I can't enable ATH10K_SNOC on x86 and hence I
> don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve
> that? IIRC we had a similar problem with wcn36xx but I don't remember
> anymore how it was fixed.
> 

Perhaps something like:

--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -42,7 +42,8 @@ config ATH10K_USB
 
 config ATH10K_SNOC
         tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
-        depends on ATH10K && ARCH_QCOM
+        depends on ATH10K
+        depends on ARCH_QCOM || COMPILE_TEST
         ---help---
           This module adds support for integrated WCN3990 chip connected
           to system NOC(SNOC). Currently work in progress and will not


Regards,
Niklas


> -- 
> Kalle Valo
> 
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH net-next] ath10k: make some functions static

[Govind Singh]

On 2018-06-04 17:34, Niklas Cassel wrote:
> On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote:
>> Wei Yongjun <weiyongjun1@huawei.com> writes:
>> 
>> > Fixes the following sparse warnings:
>> >
>> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>> >  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
>> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>> >  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
>> >
>> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> 
>> BTW this goes to my ath.git tree, not to net-next.
>> 
>> I had missed these as I can't enable ATH10K_SNOC on x86 and hence I
>> don't test compile snoc.c at all. Bjorn&Govind, is there a way to 
>> solve
>> that? IIRC we had a similar problem with wcn36xx but I don't remember
>> anymore how it was fixed.
>> 

I tested compilation in x86 by removing ARCH_QCOM dependency last time.

> 
> Perhaps something like:
> 
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
> @@ -42,7 +42,8 @@ config ATH10K_USB
> 
>  config ATH10K_SNOC
>          tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)"
> -        depends on ATH10K && ARCH_QCOM
> +        depends on ATH10K
> +        depends on ARCH_QCOM || COMPILE_TEST
>          ---help---
>            This module adds support for integrated WCN3990 chip 
> connected
>            to system NOC(SNOC). Currently work in progress and will not
> 
> 
> Regards,
> Niklas
> 

Yes, This looks more appropriate and works well.


BR,
Govind

Re: [PATCH net-next] ath10k: make some functions static

[Kalle Valo]

Wei Yongjun <weiyongjun1@huawei.com> writes:

> Fixes the following sparse warnings:
>
> drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
> drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Your name in patchwork is wrong[1] and hence my script uses the wrong
name. Please fix it by registering to patchwork[2] where it's possible
to change your name during registration, but only one time. If that
doesn't work then send a request to helpdesk@kernel.org and the admins
can fix it.

But no need to resend this patch, I can fix your name manually this
time.

[1] "weiyongjun (A)" in https://patchwork.kernel.org/patch/10440159/

[2] https://patchwork.kernel.org/register/


-- 
Kalle Valo

Re: [PATCH net-next] ath10k: make some functions static

[Dan Carpenter]

On Thu, Jun 14, 2018 at 11:55:44AM +0300, Kalle Valo wrote:
> Wei Yongjun <weiyongjun1@huawei.com> writes:
> 
> > Fixes the following sparse warnings:
> >
> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
> >  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
> >  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Your name in patchwork is wrong[1] and hence my script uses the wrong
> name. Please fix it by registering to patchwork[2] where it's possible
> to change your name during registration, but only one time. If that
> doesn't work then send a request to helpdesk@kernel.org and the admins
> can fix it.
> 
> But no need to resend this patch, I can fix your name manually this
> time.
> 
> [1] "weiyongjun (A)" in https://patchwork.kernel.org/patch/10440159/
> 
> [2] https://patchwork.kernel.org/register/

That's a weird patchwork issue...  It sounds like this is a known bug?

regards,
dan carpenter

Re: [PATCH net-next] ath10k: make some functions static

[Kalle Valo]

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Thu, Jun 14, 2018 at 11:55:44AM +0300, Kalle Valo wrote:
>> Wei Yongjun <weiyongjun1@huawei.com> writes:
>> 
>> > Fixes the following sparse warnings:
>> >
>> > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>> >  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
>> > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>> >  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
>> >
>> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> 
>> Your name in patchwork is wrong[1] and hence my script uses the wrong
>> name. Please fix it by registering to patchwork[2] where it's possible
>> to change your name during registration, but only one time. If that
>> doesn't work then send a request to helpdesk@kernel.org and the admins
>> can fix it.
>> 
>> But no need to resend this patch, I can fix your name manually this
>> time.
>> 
>> [1] "weiyongjun (A)" in https://patchwork.kernel.org/patch/10440159/
>> 
>> [2] https://patchwork.kernel.org/register/
>
> That's a weird patchwork issue...  It sounds like this is a known bug?

Yeah, it's a known bug. Patchwork stores the name from the first mail it
sees from the user and it's impossible to change it afterwards (or
something like that). I think it's fixed in the latest patchwork version
but kernel.org admins are really slow updating patchwork.kernel.org.

In all these cases I direct the users to contact helpdesk, hopefully
that eventually gives admins enough motivation to update patchwork :)

-- 
Kalle Valo

Re: [PATCH net-next] ath10k: make some functions static

[Dan Carpenter]

Ah...  Thanks for the explanation.  I was really confused how it got the
name wrong.

regards,
dan carpenter

Re: [net-next] ath10k: make some functions static

[Kalle Valo]

"weiyongjun \(A\)" <weiyongjun1@huawei.com> wrote:

> Fixes the following sparse warnings:
> 
> drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning:
>  symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static?
> drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning:
>  symbol 'ath10k_snoc_init_napi' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

6ee0e175a33d ath10k: make some functions static

-- 
https://patchwork.kernel.org/patch/10440159/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches