* [PATCH v2 3/6] dt: bindings: add bindings for msa memory region @ 2018-06-05 12:36 Govind Singh 2018-06-05 23:18 ` Brian Norris 0 siblings, 1 reply; 5+ messages in thread From: Govind Singh @ 2018-06-05 12:36 UTC (permalink / raw) To: devicetree, andy.gross, bjorn.andersson, david.brown, linux-wireless, ath10k Cc: Govind Singh Add device tree binding documentation details of msa memory region for ath10k qmi client for SDM845/APQ8098 SoC into "qcom,ath10k.txt". Signed-off-by: Govind Singh <govinds@codeaurora.org> --- .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 7fd4e8ce4149..0efc47f4ba34 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -56,6 +56,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" is "vdd-0.8-cx-mx". +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. +- msa-size: MSA memory size for fw internal use. Example (to supply the calibration data alone): @@ -133,6 +135,8 @@ wifi@18000000 { compatible = "qcom,wcn3990-wifi"; reg = <0x18800000 0x800000>; reg-names = "membase"; + msa-fixed-region = <&wlan_msa_mem>; + msa-size = <0x100000>; clocks = <&clock_gcc clk_aggre2_noc_clk>; clock-names = "smmu_aggre2_noc_clk" interrupts = -- 2.17.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region 2018-06-05 12:36 [PATCH v2 3/6] dt: bindings: add bindings for msa memory region Govind Singh @ 2018-06-05 23:18 ` Brian Norris 2018-07-03 15:42 ` Kalle Valo 0 siblings, 1 reply; 5+ messages in thread From: Brian Norris @ 2018-06-05 23:18 UTC (permalink / raw) To: Govind Singh Cc: devicetree, andy.gross, bjorn.andersson, david.brown, linux-wireless, ath10k, Rob Herring + Rob On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote: > Add device tree binding documentation details of msa > memory region for ath10k qmi client for SDM845/APQ8098 > SoC into "qcom,ath10k.txt". > > Signed-off-by: Govind Singh <govinds@codeaurora.org> > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 7fd4e8ce4149..0efc47f4ba34 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -56,6 +56,8 @@ Optional properties: > the length can vary between hw versions. > - <supply-name>-supply: handle to the regulator device tree node > optional "supply-name" is "vdd-0.8-cx-mx". > +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. As in reserved-memory/reserved-memory.txt? Might refer to that doc here. Or is this some other kind of reserved memory? If the former, it's normally called just "memory-region", although that does seem somewhat non-descriptive... > +- msa-size: MSA memory size for fw internal use. Do you really need both of these? It seems like your code uses one or the other, not both. In which case, this is not a very good description, because it sounds like they would go together. Also, if you're not using standard/generic properties (e.g., the aforementioned "memory-region" binding), you typically should use a vendor prefix, like "qcom,msa-size". Brian > > Example (to supply the calibration data alone): > > @@ -133,6 +135,8 @@ wifi@18000000 { > compatible = "qcom,wcn3990-wifi"; > reg = <0x18800000 0x800000>; > reg-names = "membase"; > + msa-fixed-region = <&wlan_msa_mem>; > + msa-size = <0x100000>; > clocks = <&clock_gcc clk_aggre2_noc_clk>; > clock-names = "smmu_aggre2_noc_clk" > interrupts = > -- > 2.17.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region 2018-06-05 23:18 ` Brian Norris @ 2018-07-03 15:42 ` Kalle Valo 2018-07-03 16:01 ` Mark Rutland 0 siblings, 1 reply; 5+ messages in thread From: Kalle Valo @ 2018-07-03 15:42 UTC (permalink / raw) To: Brian Norris Cc: Govind Singh, devicetree, linux-wireless, ath10k, bjorn.andersson, david.brown, Rob Herring, andy.gross Brian Norris <briannorris@chromium.org> writes: > + Rob > > On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote: >> Add device tree binding documentation details of msa >> memory region for ath10k qmi client for SDM845/APQ8098 >> SoC into "qcom,ath10k.txt". >> >> Signed-off-by: Govind Singh <govinds@codeaurora.org> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 7fd4e8ce4149..0efc47f4ba34 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -56,6 +56,8 @@ Optional properties: >> the length can vary between hw versions. >> - <supply-name>-supply: handle to the regulator device tree node >> optional "supply-name" is "vdd-0.8-cx-mx". >> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. > > As in reserved-memory/reserved-memory.txt? Might refer to that doc here. > Or is this some other kind of reserved memory? > > If the former, it's normally called just "memory-region", although > that does seem somewhat non-descriptive... > >> +- msa-size: MSA memory size for fw internal use. > > Do you really need both of these? It seems like your code uses one or > the other, not both. In which case, this is not a very good description, > because it sounds like they would go together. > > Also, if you're not using standard/generic properties (e.g., the > aforementioned "memory-region" binding), you typically should use a > vendor prefix, like "qcom,msa-size". Devicetree folks, any comments? I would like to apply this via my ath.git tree but need help with the review. Full patch here: https://patchwork.kernel.org/patch/10448169/ -- Kalle Valo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region 2018-07-03 15:42 ` Kalle Valo @ 2018-07-03 16:01 ` Mark Rutland 2018-07-04 9:51 ` Govind Singh 0 siblings, 1 reply; 5+ messages in thread From: Mark Rutland @ 2018-07-03 16:01 UTC (permalink / raw) To: Kalle Valo Cc: Brian Norris, Govind Singh, devicetree, linux-wireless, ath10k, bjorn.andersson, david.brown, Rob Herring, andy.gross On Tue, Jul 03, 2018 at 06:42:24PM +0300, Kalle Valo wrote: > Brian Norris <briannorris@chromium.org> writes: > > > + Rob > > > > On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote: > >> Add device tree binding documentation details of msa > >> memory region for ath10k qmi client for SDM845/APQ8098 > >> SoC into "qcom,ath10k.txt". > >> > >> Signed-off-by: Govind Singh <govinds@codeaurora.org> > >> --- > >> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> index 7fd4e8ce4149..0efc47f4ba34 100644 > >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> @@ -56,6 +56,8 @@ Optional properties: > >> the length can vary between hw versions. > >> - <supply-name>-supply: handle to the regulator device tree node > >> optional "supply-name" is "vdd-0.8-cx-mx". > >> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. > > > > As in reserved-memory/reserved-memory.txt? Might refer to that doc here. > > Or is this some other kind of reserved memory? > > > > If the former, it's normally called just "memory-region", although > > that does seem somewhat non-descriptive... > > > >> +- msa-size: MSA memory size for fw internal use. > > > > Do you really need both of these? It seems like your code uses one or > > the other, not both. In which case, this is not a very good description, > > because it sounds like they would go together. > > > > Also, if you're not using standard/generic properties (e.g., the > > aforementioned "memory-region" binding), you typically should use a > > vendor prefix, like "qcom,msa-size". > > Devicetree folks, any comments? I would like to apply this via my > ath.git tree but need help with the review. I think Brian's comments w.r.t msa-size and msa-fixed-region both stand. It would be good if Govind could answer his questions. Thanks, Mark. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 3/6] dt: bindings: add bindings for msa memory region 2018-07-03 16:01 ` Mark Rutland @ 2018-07-04 9:51 ` Govind Singh 0 siblings, 0 replies; 5+ messages in thread From: Govind Singh @ 2018-07-04 9:51 UTC (permalink / raw) To: Mark Rutland Cc: Kalle Valo, Brian Norris, devicetree, linux-wireless, ath10k, bjorn.andersson, david.brown, Rob Herring, andy.gross On 2018-07-03 21:31, Mark Rutland wrote: > On Tue, Jul 03, 2018 at 06:42:24PM +0300, Kalle Valo wrote: >> Brian Norris <briannorris@chromium.org> writes: >> >> > + Rob >> > >> > On Tue, Jun 05, 2018 at 06:06:16PM +0530, Govind Singh wrote: >> >> Add device tree binding documentation details of msa >> >> memory region for ath10k qmi client for SDM845/APQ8098 >> >> SoC into "qcom,ath10k.txt". >> >> >> >> Signed-off-by: Govind Singh <govinds@codeaurora.org> >> >> --- >> >> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ >> >> 1 file changed, 4 insertions(+) >> >> >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> >> index 7fd4e8ce4149..0efc47f4ba34 100644 >> >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> >> @@ -56,6 +56,8 @@ Optional properties: >> >> the length can vary between hw versions. >> >> - <supply-name>-supply: handle to the regulator device tree node >> >> optional "supply-name" is "vdd-0.8-cx-mx". >> >> +- msa-fixed-region: phandle, specifier to children of reserved MSA memory. >> > >> > As in reserved-memory/reserved-memory.txt? Might refer to that doc here. >> > Or is this some other kind of reserved memory? >> > sure, i will give reference to reserved-memory.txt. >> > If the former, it's normally called just "memory-region", although >> > that does seem somewhat non-descriptive... >> > >> >> +- msa-size: MSA memory size for fw internal use. >> > >> > Do you really need both of these? It seems like your code uses one or >> > the other, not both. In which case, this is not a very good description, >> > because it sounds like they would go together. >> > >> > Also, if you're not using standard/generic properties (e.g., the >> > aforementioned "memory-region" binding), you typically should use a >> > vendor prefix, like "qcom,msa-size". >> >> Devicetree folks, any comments? I would like to apply this via my >> ath.git tree but need help with the review. > > I think Brian's comments w.r.t msa-size and msa-fixed-region both > stand. > It would be good if Govind could answer his questions. > As Brian suggested, i am planing to remove msa-size and keep only msa-fixed-region. Thanks Govind ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-04 9:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-06-05 12:36 [PATCH v2 3/6] dt: bindings: add bindings for msa memory region Govind Singh 2018-06-05 23:18 ` Brian Norris 2018-07-03 15:42 ` Kalle Valo 2018-07-03 16:01 ` Mark Rutland 2018-07-04 9:51 ` Govind Singh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).