linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Wirz <spam@lukas-wirz.de>
Cc: b43-dev@lists.infradead.org,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: b43 crashes on rmmod (bcm4331)
Date: Wed, 13 Jun 2018 12:27:51 +0200	[thread overview]
Message-ID: <20180613122751.2fe89737@wiggum> (raw)
In-Reply-To: <7d564b8b-2b71-73f6-3ae7-ede0187a4151@lukas-wirz.de>

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

On Wed, 13 Jun 2018 12:25:16 +0300
Wirz <spam@lukas-wirz.de> wrote:

> > This commit introduces a bug, if b43 is the only RNG in the system. But
> > that is unlikely on modern systems and it's fixed by
> > 0e4b52942b1c76f89e0dcb829f72e123d0678f54, which is in 4.16.
> > 
> > Other than that I currently can't see why this crashes.
> > 
> > But the crash should go away, if you disable CONFIG_B43_HWRNG.
> > That's not a solution, but it may help, if you would like to get rid of
> > the crashes.
> > Could you please verify whether disabling CONFIG_B43_HWRNG avoids the
> > crash, just to make sure we are not after a red herring here?  
> 
> It seems the bug I'm seeing is separate from the one you are describing.
>  The 4.16 kernels that ship with debian testing crash for me as well.  I
> tested the 142a27f0a version with CONFIG_B43_HWRNG switched off
> (manually in the .config): it still crashes is the same way.  I also
> just verified that the version one before that really is good.


CONFIG_B43_HWRNG completely switches off hwrng support in b43.
I don't see how a change in hwrng core could still lead to a crash in
b43 with this option switched off.

What do you mean by "manually in the .config"?
Can you try to properly switch off the setting with make menuconfig and
then recompile everything from scratch (make clean)?

-- 
Michael

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-06-13 10:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 19:55 b43 crashes on rmmod (bcm4331) Wirz
2018-06-09 12:08 ` Wirz
2018-06-09 15:11   ` Michael Büsch
2018-06-09 19:46     ` Wirz
2018-06-09 20:01       ` Michael Büsch
2018-06-11 20:09         ` Wirz
2018-06-11 20:46           ` Michael Büsch
2018-06-13  9:25             ` Wirz
2018-06-13 10:27               ` Michael Büsch [this message]
2018-06-13 11:01                 ` Wirz
2018-06-13 11:09                   ` Michael Büsch
2018-06-13 12:01                     ` Michael Büsch
2018-06-13 13:07                       ` Wirz
2018-06-13 13:28                         ` Michael Büsch
2018-06-14  9:47                           ` Wirz
2018-06-14 16:26                             ` Michael Büsch
2018-06-14 19:18                               ` Wirz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613122751.2fe89737@wiggum \
    --to=m@bues.ch \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=spam@lukas-wirz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).