linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Omer Efrat <omer.efrat@tandemg.com>,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types
Date: Fri, 15 Jun 2018 13:25:08 +0200	[thread overview]
Message-ID: <20180615112508.GA22268@kroah.com> (raw)
In-Reply-To: <1528974574.26847.4.camel@sipsolutions.net>

On Thu, Jun 14, 2018 at 01:09:34PM +0200, Johannes Berg wrote:
> On Thu, 2018-06-14 at 13:13 +0300, Omer Efrat wrote:
> > Since 'filled' member in station_info changed to u64, BIT_ULL macro
> > should be used with NL80211_STA_INFO_* attribute types instead of BIT.
> > 
> > The BIT macro uses unsigned long type which some architectures handle as 32bit
> > and this results in compilation warnings such as:
> > 
> > net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type
> >   sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
> >   ^
> 
> Same here, I don't think this patch is really needed, but I'll leave it
> up to Greg.
> 
> Greg, FWIW, only a few values are >=31 to need this, including the one
> pointed out in the commit message, but none in this code are affected.

Thanks for the warning, I'll take this just to keep things "clean".

greg k-h

  reply	other threads:[~2018-06-15 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 10:13 [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types Omer Efrat
2018-06-14 11:09 ` Johannes Berg
2018-06-15 11:25   ` Greg KH [this message]
2018-06-15 11:26 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615112508.GA22268@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=omer.efrat@tandemg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).