Re: [PATCH v2] libertas: fix suspend and resume for SDIO connected cards

[Chris Ball <chris@printf.net>]

On Wed, Jun 27, 2018 at 08:58:45PM +0200, Daniel Mack wrote:
> Prior to commit 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM
> callbacks from the sdio bus"), the MMC core used to call into the power
> management functions of SDIO clients itself and removed the card if the
> return code was non-zero. IOW, the mmc handled errors gracefully and didn't
> upchain them to the pm core.
> 
> Since this change, the mmc core relies on generic power management
> functions which treat all errors as a reason to cancel the suspend
> immediately. This causes suspend attempts to fail when the libertas
> driver is loaded.
> 
> To fix this, power down the card explicitly in if_sdio_suspend() when we
> know we're about to lose power and return success. Also set a flag in these
> cases, and power up the card again in if_sdio_resume().
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Chris Ball <chris@printf.net>

Thanks, looks good.

Reviewed-by: Chris Ball <chris@printf.net>

-- 
Chris Ball   <http://printf.net/>