linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: ulf.hansson@linaro.org, chris@printf.net,
	linux-mmc@vger.kernel.org, libertas-dev@lists.infradead.org,
	linux-wireless@vger.kernel.org, Daniel Mack <daniel@zonque.org>
Subject: Re: [v2] libertas: fix suspend and resume for SDIO connected cards
Date: Wed,  4 Jul 2018 15:13:49 +0000 (UTC)	[thread overview]
Message-ID: <20180704151349.52E3C6028D@smtp.codeaurora.org> (raw)
In-Reply-To: <20180627185845.31799-1-daniel@zonque.org>

Daniel Mack <daniel@zonque.org> wrote:

> Prior to commit 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM
> callbacks from the sdio bus"), the MMC core used to call into the power
> management functions of SDIO clients itself and removed the card if the
> return code was non-zero. IOW, the mmc handled errors gracefully and didn't
> upchain them to the pm core.
> 
> Since this change, the mmc core relies on generic power management
> functions which treat all errors as a reason to cancel the suspend
> immediately. This causes suspend attempts to fail when the libertas
> driver is loaded.
> 
> To fix this, power down the card explicitly in if_sdio_suspend() when we
> know we're about to lose power and return success. Also set a flag in these
> cases, and power up the card again in if_sdio_resume().
> 
> Fixes: 573185cc7e64 ("mmc: core: Invoke sdio func driver's PM callbacks from the sdio bus")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Reviewed-by: Chris Ball <chris@printf.net>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Patch applied to wireless-drivers-next.git, thanks.

7444a8092906 libertas: fix suspend and resume for SDIO connected cards

-- 
https://patchwork.kernel.org/patch/10492407/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      parent reply	other threads:[~2018-07-04 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 18:58 [PATCH v2] libertas: fix suspend and resume for SDIO connected cards Daniel Mack
2018-06-27 23:13 ` Chris Ball
2018-06-29 15:39 ` Ulf Hansson
2018-06-29 17:57   ` Daniel Mack
2018-07-02 14:57     ` Kalle Valo
2018-07-03  4:51       ` Ulf Hansson
2018-07-04 15:13 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704151349.52E3C6028D@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=chris@printf.net \
    --cc=daniel@zonque.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).