From: Ajay Singh <ajay.kathat@microchip.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<venkateswara.kaja@microchip.com>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <adham.abozaeid@microchip.com>,
<aditya.shankar@microchip.com>
Subject: Re: [PATCH] staging: wilc1000: fix static checker warning to unlock mutex in wilc_deinit()
Date: Thu, 5 Jul 2018 14:49:48 +0530 [thread overview]
Message-ID: <20180705144948.3d4b4e62@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180705084126.jbqiduxkq7257asu@mwanda>
Hi Dan,
On Thu, 5 Jul 2018 11:41:26 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Jul 05, 2018 at 09:18:53AM +0530, Ajay Singh wrote:
> > Fix for static checker warning inconsistent returns of
> > 'hif_deinit_lock'(more details [1]).
> >
> > "drivers/staging/wilc1000/host_interface.c:3390 wilc_deinit()
> > warn: inconsistent returns 'hif_deinit_lock'."
> >
> > Introduced in "ff52a57a7a42: staging: wilc1000: move the allocation
> > of cmd out of wilc_enqueue_cmd()".
>
> Can you use the Fixes tag so it's machine parseable?
>
> Fixes: ff52a57a7a42 ("staging: wilc1000: move the allocation of cmd
> out of wilc_enqueue_cmd()")
Thanks for your suggestion.
Will include the 'Fixes' tag and submit patch v2 version.
>
> With the fixes tag, say someone pulls ff52a57a7a42 into their code,
> they will know to pull this patch as well. Also scientists will be
> able to measure the time between bug and fix and write a scholarly
> paper about it.
>
> regards,
> dan carpenter
prev parent reply other threads:[~2018-07-05 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 3:48 [PATCH] staging: wilc1000: fix static checker warning to unlock mutex in wilc_deinit() Ajay Singh
2018-07-05 8:41 ` Dan Carpenter
2018-07-05 9:19 ` Ajay Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705144948.3d4b4e62@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).