linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Jakub Kicinski <kubakici@wp.pl>,
	Michal Schmidt <mschmidt@redhat.com>,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver
Date: Thu, 5 Jul 2018 16:50:19 +0200	[thread overview]
Message-ID: <20180705145018.GA17524@localhost.localdomain> (raw)
In-Reply-To: <1530771142-4118-12-git-send-email-sgruszka@redhat.com>

On Jul 05, Stanislaw Gruszka wrote:
> Add Kconfig and Makefiles for mt76x0 driver. Now the driver
> can be build.
> 
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
>  drivers/net/wireless/mediatek/mt76/Kconfig         | 7 +++++++
>  drivers/net/wireless/mediatek/mt76/Makefile        | 1 +
>  drivers/net/wireless/mediatek/mt76/mt76x0/Makefile | 7 +++++++
>  3 files changed, 15 insertions(+)
>  create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig
> index fc05d79c80d0..84854736809a 100644
> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> @@ -1,6 +1,13 @@
>  config MT76_CORE
>  	tristate
>  
> +config MT76x0U
> +	tristate "MediaTek MT76x0U (USB) support"
> +	depends on MAC80211
> +	depends on USB
> +	help
> +	  This adds support for MT7610U-based wireless USB dongles.
> +
>  config MT76x2E
>  	tristate "MediaTek MT76x2E (PCIe) support"
>  	select MT76_CORE
> diff --git a/drivers/net/wireless/mediatek/mt76/Makefile b/drivers/net/wireless/mediatek/mt76/Makefile
> index a0156bc01dea..08f93127e9e7 100644
> --- a/drivers/net/wireless/mediatek/mt76/Makefile
> +++ b/drivers/net/wireless/mediatek/mt76/Makefile
> @@ -1,4 +1,5 @@
>  obj-$(CONFIG_MT76_CORE) += mt76.o
> +obj-$(CONFIG_MT76x0U) += mt76x0/
>  obj-$(CONFIG_MT76x2E) += mt76x2e.o
>  
>  mt76-y := \
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> new file mode 100644
> index 000000000000..7843908261ba
> --- /dev/null
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> @@ -0,0 +1,7 @@
> +obj-$(CONFIG_MT76x0U)    += mt76x0.o
> +
> +mt76x0-objs	= \
> +	usb.o init.o main.o mcu.o trace.o dma.o eeprom.o phy.o \

There is no main.c source file, is it a leftover from previous implementation?
Moreover compiling the driver (and fixing conflicts with mt76x2u) I have:

ERROR: "mt76x0_ops" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.ko] undefined!

Regards,
Lorenzo

> +	mac.o util.o debugfs.o tx.o core.o
> +# ccflags-y := -DDEBUG
> +CFLAGS_trace.o := -I$(src)
> -- 
> 1.9.3
> 

  parent reply	other threads:[~2018-07-05 14:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  6:12 [PATCH 00/11] Add mt76x0 driver Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 01/11] mt76: add more states Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 02/11] mt76x0: core files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 03/11] mt76x0: mac files Stanislaw Gruszka
2018-07-05 15:17   ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 04/11] mt76x0: usb files Stanislaw Gruszka
2018-07-05 15:05   ` Lorenzo Bianconi
2018-07-06 10:42     ` Stanislaw Gruszka
2018-07-23  6:38     ` Kalle Valo
2018-07-23  8:57       ` Lorenzo Bianconi
2018-07-23  9:07         ` Kalle Valo
2018-07-23  9:31           ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 05/11] mt76x0: mcu files Stanislaw Gruszka
2018-07-05 15:13   ` Lorenzo Bianconi
2018-07-05  6:12 ` [PATCH 06/11] mt76x0: phy files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 07/11] mt76x0: init files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 08/11] mt76x0: eeprom files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 09/11] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 10/11] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-05  6:12 ` [PATCH 11/11] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
2018-07-05  8:40   ` kbuild test robot
2018-07-05 14:50   ` Lorenzo Bianconi [this message]
2018-07-06 10:32     ` Stanislaw Gruszka
2018-07-05 15:32 ` [PATCH 00/11] Add " Lorenzo Bianconi
2018-07-06 10:36   ` Stanislaw Gruszka
2018-07-06 11:37     ` Lorenzo Bianconi
2018-07-07  8:38   ` Hans Ulli Kroll
2018-07-20 10:30     ` Stanislaw Gruszka
2018-07-20 10:36       ` Stanislaw Gruszka
2018-07-20 12:18       ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705145018.GA17524@localhost.localdomain \
    --to=lorenzo.bianconi@redhat.com \
    --cc=kubakici@wp.pl \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).