From: Boris Brezillon <boris.brezillon@bootlin.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: "Ralf Baechle" <ralf@linux-mips.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Richard Weinberger" <richard@nod.at>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org,
"David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
"Marek Vasut" <marek.vasut@gmail.com>,
linux-wireless@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>
Subject: Re: [PATCH v2 23/24] mtd: rawnand: jz4780: Drop the dependency on MACH_JZ4780
Date: Tue, 10 Jul 2018 19:10:00 +0200 [thread overview]
Message-ID: <20180710191000.2b7c95bb@bbrezillon> (raw)
In-Reply-To: <CANc+2y5vjUpM_ikegaoKTtqehSmBY3y_r+1E6y93AoivRQqmfg@mail.gmail.com>
Hi PrasannaKumar,
On Tue, 10 Jul 2018 22:16:50 +0530
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> wrote:
> Hi Boris,
>
> On 10 July 2018 at 01:39, Boris Brezillon <boris.brezillon@bootlin.com>
> wrote:
>
> > This MACH_JZ4780 dependency is taken care of by JZ4780_NEMC, no need
> > to repeat it here.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---
> > drivers/mtd/nand/raw/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> > index 7b5e97719c25..d9cd9608bc2d 100644
> > --- a/drivers/mtd/nand/raw/Kconfig
> > +++ b/drivers/mtd/nand/raw/Kconfig
> > @@ -499,7 +499,7 @@ config MTD_NAND_JZ4740
> >
> > config MTD_NAND_JZ4780
> > tristate "Support for NAND on JZ4780 SoC"
> > - depends on MACH_JZ4780 && JZ4780_NEMC
> > + depends on JZ4780_NEMC
> > help
> > Enables support for NAND Flash connected to the NEMC on JZ4780
> > SoC
> > based boards, using the BCH controller for hardware error
> > correction.
> > --
> > 2.14.1
> >
> >
> >
> JZ4780 has MLC NAND.
Hm, the NAND controller supports both MLC and SLC NANDs. Maybe there
are only boards with MLC NANDs, but that doesn't mean we should remove
the driver for the controller.
> As MLC NAND is not supported in mainline do you think
> this patch is required? Even wondering if the driver is required at all.
The fact that MLC NANDs are not supported by UBI is not necessarily
definitive. I have a branch with all the work we've done to add MLC
support to UBI [1]. If you have time to invest in it, feel free to take
over this work.
Anyway, the decision to remove this driver is not mine, and this patch
allows me to at least compile-test this driver.
Regards,
Boris
[1]https://github.com/bbrezillon/linux/commits/nand/mlc
next prev parent reply other threads:[~2018-07-10 17:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:09 [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 01/24] mtd: rawnand: atmel: Use uintptr_t casts instead of unsigned int Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 02/24] mtd: rawnand: atmel: Add an __iomem cast on gen_pool_dma_alloc() call Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 03/24] mtd: rawnand: atmel: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 04/24] mtd: rawnand: s3c2410: " Boris Brezillon
2018-07-11 11:16 ` Boris Brezillon
2018-07-11 11:27 ` Arnd Bergmann
2018-07-11 11:32 ` Boris Brezillon
2018-07-11 12:09 ` Arnd Bergmann
2018-07-11 13:01 ` Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 05/24] mtd: rawnand: orion: Avoid direct inclusion of asm headers Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 06/24] mtd: rawnand: orion: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 07/24] mtd: rawnand: davinci: Stop doing iomem pointer <-> u32 conversions Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 08/24] mtd: rawnand: davinci: Use uintptr_t casts instead of unsigned ones Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 09/24] mtd: rawnand: davinci: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 10/24] mtd: rawnand: sunxi: Add an U suffix to NFC_PAGE_OP definition Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 11/24] mtd: rawnand: sunxi: Make sure ret is initialized in sunxi_nfc_read_byte() Boris Brezillon
2018-07-09 20:35 ` Arnd Bergmann
2018-07-09 21:00 ` Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 12/24] mtd: rawnand: sunxi: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 13/24] mtd: rawnand: fscm: Avoid collision on PC def when compiling for MIPS Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 14/24] mtd: rawnand: fsmc: Use uintptr_t casts instead of unsigned ones Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 15/24] mtd: rawnand: fsmc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 16/24] memory: fsl_ifc: " Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 17/24] mtd: rawnand: fsl_ifc: Add an __iomem specifier on eccstat_regs Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 18/24] mtd: rawnand: fsl_ifc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 19/24] MIPS: txx9: Move the ndfc.h header to include/linux/platform_data/txx9 Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 20/24] mtd: rawnand: txx9ndfmc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 21/24] MIPS: jz4740: Move jz4740_nand.h header to include/linux/platform_data/jz4740 Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 22/24] mtd: rawnand: jz4740: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:09 ` [PATCH v2 23/24] mtd: rawnand: jz4780: Drop the dependency on MACH_JZ4780 Boris Brezillon
[not found] ` <CANc+2y5vjUpM_ikegaoKTtqehSmBY3y_r+1E6y93AoivRQqmfg@mail.gmail.com>
2018-07-10 17:10 ` Boris Brezillon [this message]
2018-07-11 17:24 ` PrasannaKumar Muralidharan
2018-07-09 20:09 ` [PATCH v2 24/24] memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y Boris Brezillon
2018-07-09 20:45 ` [PATCH v2 00/24] mtd: rawnand: Improve compile-test coverage Arnd Bergmann
2018-07-10 18:51 ` Paul Burton
2018-07-18 7:13 ` Miquel Raynal
2018-07-18 7:15 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710191000.2b7c95bb@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prasannatsmkumar@gmail.com \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).