From: Daniel Mack <daniel@zonque.org>
To: sameo@linux.intel.com
Cc: linux-wireless@vger.kernel.org, colin.king@canonical.com,
shikha.singh@st.com, Daniel Mack <daniel@zonque.org>
Subject: [PATCH 03/10] NFC: st95hf: drop illegal kfree_skb() in IRQ handler
Date: Mon, 23 Jul 2018 16:00:08 +0200 [thread overview]
Message-ID: <20180723140015.11663-4-daniel@zonque.org> (raw)
In-Reply-To: <20180723140015.11663-1-daniel@zonque.org>
In the error path of the IRQ handler, don't free the skb in flight. The
callback in the digital core will do that for us. Doing it from both
places causes memory corruptions.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/nfc/st95hf/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
index d58424ab5c48..d857197ec7b2 100644
--- a/drivers/nfc/st95hf/core.c
+++ b/drivers/nfc/st95hf/core.c
@@ -863,7 +863,6 @@ static irqreturn_t st95hf_irq_thread_handler(int irq, void *st95hfcontext)
return IRQ_HANDLED;
end:
- kfree_skb(skb_resp);
wtx = false;
cb_arg->rats = false;
skb_resp = ERR_PTR(result);
--
2.17.1
next prev parent reply other threads:[~2018-07-23 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 14:00 [PATCH 00/10] NFC: A bunch of cleanups for st95hf Daniel Mack
2018-07-23 14:00 ` [PATCH 01/10] Revert "NFC: st95hf: drop illegal kfree_skb()" Daniel Mack
2018-07-23 14:00 ` [PATCH 02/10] NFC: st95hf: drop nfcdev_free Daniel Mack
2018-07-23 14:00 ` Daniel Mack [this message]
2018-07-23 14:00 ` [PATCH 04/10] NFC: st95hf: remove logging from spi functions Daniel Mack
2018-07-23 14:00 ` [PATCH 05/10] NFC: st95hf: remove exchange_lock Daniel Mack
2018-07-23 14:00 ` [PATCH 06/10] NFC: st95hf: move skb allocation to ISR Daniel Mack
2018-07-23 14:00 ` [PATCH 07/10] NFC: st95hf: re-order command defines Daniel Mack
2018-07-23 14:00 ` [PATCH 08/10] NFC: st95hf: unify sync/async flags Daniel Mack
2018-07-23 14:00 ` [PATCH 09/10] NFC: st95hf: two small style nits Daniel Mack
2018-07-23 14:00 ` [PATCH 10/10] NFC: st95hf: add of match table Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723140015.11663-4-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=colin.king@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=shikha.singh@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).