From: Felix Fietkau <nbd@nbd.name>
To: linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org
Subject: [PATCH 9/9] ath9k: fix more-data flag for buffered multicast packets
Date: Mon, 23 Jul 2018 18:03:00 +0200 [thread overview]
Message-ID: <20180723160300.58024-9-nbd@nbd.name> (raw)
In-Reply-To: <20180723160300.58024-1-nbd@nbd.name>
The flag needs to be cleared for the last packet in the list, not the
first one. Fixes some issues with multicast packet loss for powersave
clients connected to an ath9k AP.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/wireless/ath/ath9k/xmit.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index bae0f6c045e1..43b6c8508e49 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -2436,7 +2436,6 @@ void ath_tx_cabq(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
.txq = sc->beacon.cabq
};
struct ath_tx_info info = {};
- struct ieee80211_hdr *hdr;
struct ath_buf *bf_tail = NULL;
struct ath_buf *bf;
LIST_HEAD(bf_q);
@@ -2480,15 +2479,10 @@ void ath_tx_cabq(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
if (list_empty(&bf_q))
return;
- bf = list_first_entry(&bf_q, struct ath_buf, list);
- hdr = (struct ieee80211_hdr *) bf->bf_mpdu->data;
-
- if (hdr->frame_control & cpu_to_le16(IEEE80211_FCTL_MOREDATA)) {
- hdr->frame_control &= ~cpu_to_le16(IEEE80211_FCTL_MOREDATA);
- dma_sync_single_for_device(sc->dev, bf->bf_buf_addr,
- sizeof(*hdr), DMA_TO_DEVICE);
- }
+ bf = list_last_entry(&bf_q, struct ath_buf, list);
+ ath9k_set_moredata(sc, bf, false);
+ bf = list_first_entry(&bf_q, struct ath_buf, list);
ath_txq_lock(sc, txctl.txq);
ath_tx_fill_desc(sc, bf, txctl.txq, 0);
ath_tx_txqaddbuf(sc, txctl.txq, &bf_q, false);
--
2.17.0
next prev parent reply other threads:[~2018-07-23 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 16:02 [PATCH 1/9] ath9k_hw: set spectral scan enable bit on trigger for AR9003+ Felix Fietkau
2018-07-23 16:02 ` [PATCH 2/9] ath9k: don't run periodic and nf calibation at the same time Felix Fietkau
2018-07-23 16:02 ` [PATCH 3/9] ath9k: force rx_clear when disabling rx Felix Fietkau
2018-07-30 18:07 ` Kalle Valo
2018-07-23 16:02 ` [PATCH 4/9] ath9k: fix moredata bit in PS buffered frame release Felix Fietkau
2018-07-30 18:08 ` Kalle Valo
2018-07-23 16:02 ` [PATCH 5/9] ath9k: clear potentially stale EOSP status bit in intermediate queues Felix Fietkau
2018-07-23 16:02 ` [PATCH 6/9] ath9k: report tx status on EOSP Felix Fietkau
2018-07-23 16:02 ` [PATCH 7/9] ath9k: fix block-ack window tracking issues Felix Fietkau
2018-07-23 16:02 ` [PATCH 8/9] ath9k_hw: fix channel maximum power level test Felix Fietkau
2018-07-23 16:03 ` Felix Fietkau [this message]
2018-07-31 7:55 ` [PATCH 1/9] ath9k_hw: set spectral scan enable bit on trigger for AR9003+ Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723160300.58024-9-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).