linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@zonque.org>
To: sameo@linux.intel.com
Cc: linux-wireless@vger.kernel.org, colin.king@canonical.com,
	shikha.singh@st.com, Daniel Mack <daniel@zonque.org>
Subject: [PATCH v2 01/10] Revert "NFC: st95hf: drop illegal kfree_skb()"
Date: Tue, 24 Jul 2018 10:54:17 +0200	[thread overview]
Message-ID: <20180724085426.23999-2-daniel@zonque.org> (raw)
In-Reply-To: <20180724085426.23999-1-daniel@zonque.org>

This reverts commit c99f996b2ba49 ("NFC: st95hf: drop illegal
kfree_skb()").

It turns out that the st95hf_in_send_cmd() is in fact the sole owner of
this skb, and by not freeing it here, we not only causing a memory leak
but also mess up the refcount of the socket that holds it. This will in
turn lead to activated targets not being cleaned up, even after
stopping userspace processes.

The memory corruption that I was hunting was caused by another
kfree_skb(). This will be fixed in a later commit.

Signed-off-by: Daniel Mack <daniel@zonque.org>
Fixes: c99f996b2ba49 ("NFC: st95hf: drop illegal kfree_skb()")
---
 drivers/nfc/st95hf/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c
index 36ef0e905ba3..bc1a2070f9bb 100644
--- a/drivers/nfc/st95hf/core.c
+++ b/drivers/nfc/st95hf/core.c
@@ -991,6 +991,8 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev,
 		goto free_skb_resp;
 	}
 
+	kfree_skb(skb);
+
 	return rc;
 
 free_skb_resp:
-- 
2.17.1

  reply	other threads:[~2018-07-24 10:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:54 [PATCH v2 00/10] NFC: A bunch of cleanups for st95hf Daniel Mack
2018-07-24  8:54 ` Daniel Mack [this message]
2018-07-24  8:54 ` [PATCH v2 02/10] NFC: st95hf: drop nfcdev_free Daniel Mack
2018-07-24  8:54 ` [PATCH v2 03/10] NFC: st95hf: drop illegal kfree_skb() in IRQ handler Daniel Mack
2018-07-24  8:54 ` [PATCH v2 04/10] NFC: st95hf: remove logging from spi functions Daniel Mack
2018-07-24  8:54 ` [PATCH v2 05/10] NFC: st95hf: remove exchange_lock Daniel Mack
2018-07-24  8:54 ` [PATCH v2 06/10] NFC: st95hf: move skb allocation to ISR Daniel Mack
2018-07-24  8:54 ` [PATCH v2 07/10] NFC: st95hf: re-order command defines Daniel Mack
2018-07-24  8:54 ` [PATCH v2 08/10] NFC: st95hf: unify sync/async flags Daniel Mack
2018-07-24  8:54 ` [PATCH v2 09/10] NFC: st95hf: two small style nits Daniel Mack
2018-07-24  8:54 ` [PATCH v2 10/10] NFC: st95hf: add of match table Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724085426.23999-2-daniel@zonque.org \
    --to=daniel@zonque.org \
    --cc=colin.king@canonical.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=shikha.singh@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).