Linux wireless drivers development
 help / color / mirror / Atom feed
From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
	Andrey Shevchenko <ashevchenko@quantenna.com>,
	Sergei Maksimenko <smaksimenko@quantenna.com>
Subject: Re: [PATCH 6/6] qtnfmac: implement basic WoWLAN support
Date: Tue, 31 Jul 2018 12:59:31 +0300	[thread overview]
Message-ID: <20180731095929.nskgxmi3siyrjvvv@bars> (raw)
In-Reply-To: <20180730141342.B613A61D77@smtp.codeaurora.org>


Hello Kalle,

> > This patch implements core WoWLAN support in qtnfmac driver, including
> > processing of WoWLAN features reported by firmware and implementation
> > of cfg80211 suspend/resume/wakeup callbacks. Currently the following
> > WoWLAN triggers are supported: disconnect, magic packet,
> > custom pattern packet.
> >
> > Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
> 
> Doesn't apply anymore as I dropped patch 5
> 
> fatal: sha1 information is lacking or useless (drivers/net/wireless/quantenna/qtnfmac/cfg80211.c).
> error: could not build fake ancestor
> Applying: qtnfmac: implement basic WoWLAN support
> Patch failed at 0001 qtnfmac: implement basic WoWLAN support
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> 
> Patch set to Changes Requested.

Thanks for review. I will rebase the remaining patches on top of your
up-to-date tree and resubmit.

As for the patch with vendor specific commands, I will split it into
a separate discussion and make another attempt to convince you, adding
proper description. IIRC there is no generic functionality suitable
for this particular usecase.

Regards,
Sergey

  reply	other threads:[~2018-07-31 11:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31  9:10 [PATCH 0/6] qtnfmac: enable more features Sergey Matyukevich
2018-05-31  9:10 ` [PATCH 1/6] qtnfmac: implement net_device_ops callback to set MAC address Sergey Matyukevich
2018-06-27 15:54   ` [1/6] " Kalle Valo
     [not found]   ` <20180627155439.481E76034E@smtp.codeaurora.org>
2018-06-29  9:26     ` Sergey Matyukevich
2018-06-29  9:43       ` Kalle Valo
2018-06-29 12:03         ` Sergey Matyukevich
2018-05-31  9:10 ` [PATCH 2/6] qtnfmac: enable source MAC address randomization support Sergey Matyukevich
2018-05-31  9:10 ` [PATCH 3/6] qtnfmac: implement cfg80211 power management callback Sergey Matyukevich
2018-06-01  1:04   ` Igor Mitsyanko
2018-06-04 12:50     ` Sergey Matyukevich
2018-06-04 18:58       ` Igor Mitsyanko
2018-07-30 13:55   ` Kalle Valo
2018-07-30 14:12   ` Kalle Valo
2018-05-31  9:11 ` [PATCH 4/6] qtnfmac: enable multiple SSIDs scan support Sergey Matyukevich
2018-05-31  9:11 ` [PATCH 5/6] qtnfmac: add support for PTA configuration Sergey Matyukevich
2018-07-30 14:06   ` Kalle Valo
2018-07-31 11:42     ` Arend van Spriel
2018-08-01  8:23       ` Sergey Matyukevich
2018-08-04 22:19         ` Arend van Spriel
2018-08-05 15:22           ` Sergey Matyukevich
2018-08-05 21:34             ` Arend van Spriel
2018-08-01  8:25       ` Kalle Valo
2018-05-31  9:11 ` [PATCH 6/6] qtnfmac: implement basic WoWLAN support Sergey Matyukevich
2018-07-30 14:13   ` Kalle Valo
2018-07-31  9:59     ` Sergey Matyukevich [this message]
2018-08-01  8:38       ` Kalle Valo
2018-05-31  9:36 ` [PATCH 0/6] qtnfmac: enable more features Kalle Valo
2018-05-31 10:35   ` Sergey Matyukevich
2018-05-31 11:12     ` Kalle Valo
2018-06-01  1:08 ` Igor Mitsyanko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731095929.nskgxmi3siyrjvvv@bars \
    --to=sergey.matyukevich.os@quantenna.com \
    --cc=ashevchenko@quantenna.com \
    --cc=igor.mitsyanko.os@quantenna.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=smaksimenko@quantenna.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox