* b43legacy/leds: Ensure NUL-termination of LED name string
@ 2018-07-31 19:14 Michael Büsch
2018-08-09 15:45 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Michael Büsch @ 2018-07-31 19:14 UTC (permalink / raw)
To: Kalle Valo; +Cc: Larry Finger, Rafał Miłecki, linux-wireless, b43-dev
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
strncpy might not NUL-terminate the string, if the name equals the buffer size.
Use strlcpy instead.
Signed-off-by: Michael Buesch <m@bues.ch>
Cc: stable@vger.kernel.org
---
drivers/net/wireless/broadcom/b43legacy/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/leds.c b/drivers/net/wireless/broadcom/b43legacy/leds.c
index fd4565389c77..bc922118b6ac 100644
--- a/drivers/net/wireless/broadcom/b43legacy/leds.c
+++ b/drivers/net/wireless/broadcom/b43legacy/leds.c
@@ -101,7 +101,7 @@ static int b43legacy_register_led(struct b43legacy_wldev *dev,
led->dev = dev;
led->index = led_index;
led->activelow = activelow;
- strncpy(led->name, name, sizeof(led->name));
+ strlcpy(led->name, name, sizeof(led->name));
led->led_dev.name = led->name;
led->led_dev.default_trigger = default_trigger;
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: b43legacy/leds: Ensure NUL-termination of LED name string
2018-07-31 19:14 b43legacy/leds: Ensure NUL-termination of LED name string Michael Büsch
@ 2018-08-09 15:45 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-08-09 15:45 UTC (permalink / raw)
To: Michael Büsch
Cc: Larry Finger, Rafał Miłecki, linux-wireless, b43-dev
Michael B=C3=BCsch <m@bues.ch> writes:
> strncpy might not NUL-terminate the string, if the name equals the buffer=
size.
> Use strlcpy instead.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
> Cc: stable@vger.kernel.org
Applied manually:
4d77a89e3924 b43legacy/leds: Ensure NUL-termination of LED name string
--=20
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-09 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-31 19:14 b43legacy/leds: Ensure NUL-termination of LED name string Michael Büsch
2018-08-09 15:45 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).