From: Ajay Singh <ajay.kathat@microchip.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<venkateswara.kaja@microchip.com>, <ganesh.krishna@microchip.com>,
<adham.abozaeid@microchip.com>, <aditya.shankar@microchip.com>
Subject: Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue
Date: Thu, 2 Aug 2018 13:56:49 +0530 [thread overview]
Message-ID: <20180802135649.13ea4059@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180802073454.GC14107@kroah.com>
Hi Greg,
On Thu, 2 Aug 2018 09:34:54 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote:
> > Cleanup patch to fix below checkpatch reported issue:
> > -#define ISWILC1000(id) ((id & 0xfffff000)
> > == 0x100000 ? 1 : 0) +#define ISWILC1000(id) (((id)
> > & 0xfffff000) == 0x100000 ? 1 : 0)
>
> Even better, make this an inline function that returns a boolean to
> avoid any potental problems.
>
Sure, I will make these changes and submit new patch.
Regards
Ajay
prev parent reply other threads:[~2018-08-02 10:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 6:06 [PATCH 0/8] staging: wilc1000: changes to address TODO items Ajay Singh
2018-07-29 6:06 ` [PATCH 1/8] staging: wilc1000: fix TODO to compile spi and sdio components in single module Ajay Singh
2018-07-29 6:06 ` [PATCH 2/8] staging: wilc1000: remove unnecessary comments and comments description Ajay Singh
2018-07-29 6:06 ` [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file Ajay Singh
2018-08-02 7:33 ` Greg KH
2018-08-02 8:24 ` Ajay Singh
2018-07-29 6:06 ` [PATCH 4/8] staging: wilc1000: modified debug log messages description Ajay Singh
2018-07-29 6:06 ` [PATCH 5/8] staging: wilc1000: added comments for 'hif_cs' mutex lock Ajay Singh
2018-07-29 6:06 ` [PATCH 6/8] staging: wilc1000: rename 'rcvd_ch_cnt' element in 'user_scan_req' struct Ajay Singh
2018-07-29 6:06 ` [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range Ajay Singh
2018-08-02 7:34 ` Greg KH
2018-08-03 8:28 ` Ajay Singh
2018-08-05 14:11 ` Greg KH
2018-08-04 15:37 ` Ajay Singh
2018-07-29 6:06 ` [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue Ajay Singh
2018-08-02 7:34 ` Greg KH
2018-08-02 8:26 ` Ajay Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802135649.13ea4059@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).