Re: [PATCH v2] staging: wilc1000: fix undefined reference to `__this_module' compilation error

[Ajay Singh <ajay.kathat@microchip.com>]

Hi Greg,

On Thu, 9 Aug 2018 14:21:33 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Thu, Aug 09, 2018 at 04:59:39PM +0530, Ajay Singh wrote:
> > wilc_debug.o object file is included for both SDIO and SPI module.
> > When anyone(either SDIO or SPI) module is compiled as loaded module
> > and another as buildin module then below compilation error occurs.
> > 
> > "drivers/staging/wilc1000/wilc_debugfs.o:(.data+0x10): undefined
> > reference to `__this_module'"
> > 
> > Moved the declaration of file_operation variable in SDIO/SPI files
> > and pass this as parameter to wilc_debugfs_init().
> > Refactor wilc_debugfs_init() as its not required to maintain
> > 'wilc_debugfs_info_t' in debugfs_info[] array. Also modified file
> > permission from 0666 to 0600 & use 'data' field as 'NULL' in
> > debugfs_create_file() call.  
> 
> That is a lot of different things all in one patch.  Please never do
> that.
> 

Please ignore this patch. I have split these changes and resubmitted a
new patch series to address this issue.

Regards,
Ajay