From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Craig Matsuura <cmatsuura@vivint.com>,
Kofi Agor <nenekofi@gmail.com>,
Enrico Mioso <mrkiko.rs@gmail.com>,
Mathias Kresin <dev@kresin.me>,
Tom Psyborg <pozega.tomislav@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>,
Jamie Stuart <jamie@onebillion.org>
Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?
Date: Mon, 20 Aug 2018 14:20:42 +0200 [thread overview]
Message-ID: <20180820122041.GA8109@redhat.com> (raw)
In-Reply-To: <20180818160836.GB1468@makrotopia.org>
Hi Daniel
On Sat, Aug 18, 2018 at 06:08:40PM +0200, Daniel Golle wrote:
> Still seeing a lot of those
>
> Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8364.972151] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
> Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8364.981622] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
> Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8364.991070] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
> Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8365.000506] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
> Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8365.009935] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2
>
> while wifi somehow keeps working at degraded level once the error
> occured.
I would like to know why we get those errors at all. Perhaps there is
something wrong with queue pause/unpasue logic. Or with locking.
Or maybe this is normal, we pausue queue in mac80211 but it still have
some pending skbs which are scheduled to the driver.
Let's check if pausing is correct. Please apply this patch:
https://github.com/sgruszka/wireless-drivers-next/commit/525c50486e17446793b21ac7a8498cb48b3bb210.patch
and provide dmesg output.
Note that adding printk messages can make itself somehow AP
unresponsive, as I pointed earlier in this thread. However
at this point I would like to check if queue pause works as it
should in the driver.
Also, how do test? I can not reproduce those errors.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-08-20 15:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 20:51 ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...? Enrico Mioso
2017-12-13 15:20 ` Stanislaw Gruszka
2017-12-16 18:33 ` Enrico Mioso
2017-12-18 15:21 ` Stanislaw Gruszka
2017-12-19 12:27 ` Stanislaw Gruszka
2017-12-19 12:39 ` Enrico Mioso
2017-12-19 12:43 ` Enrico Mioso
2017-12-19 12:54 ` Stanislaw Gruszka
2017-12-19 13:25 ` Enrico Mioso
2017-12-20 17:49 ` Enrico Mioso
2017-12-21 14:25 ` Stanislaw Gruszka
2017-12-24 12:19 ` Enrico Mioso
2018-01-03 11:35 ` Stanislaw Gruszka
2018-01-03 14:04 ` Enrico Mioso
[not found] ` <CAKR_QVLRwAA0NJSarX46J4A8XSp8h5SuTEtSBQ4ydpEPh_-aUw@mail.gmail.com>
2018-01-22 5:45 ` Enrico Mioso
2018-01-23 13:22 ` Stanislaw Gruszka
2018-01-24 5:14 ` Enrico Mioso
2018-01-24 8:18 ` Enrico Mioso
2018-01-24 10:03 ` Stanislaw Gruszka
2018-03-01 15:30 ` Daniel Golle
2018-03-02 19:13 ` Enrico Mioso
2018-03-07 12:27 ` Stanislaw Gruszka
2018-03-07 12:29 ` Stanislaw Gruszka
2018-03-23 7:51 ` Mathias Kresin
2018-03-26 10:35 ` Stanislaw Gruszka
2018-03-27 7:46 ` Mathias Kresin
2018-03-27 17:18 ` Stanislaw Gruszka
2018-03-27 17:43 ` Daniel Golle
2018-03-28 4:14 ` Enrico Mioso
[not found] ` <CAOt++SeSQ2j1KuVkbqt77LfznXN7JV0Lx5O8d7-m2VBrz8=85g@mail.gmail.com>
2018-03-29 5:13 ` Enrico Mioso
2018-03-30 14:41 ` Enrico Mioso
2018-03-30 14:44 ` Enrico Mioso
[not found] ` <MWHPR02MB3326233159B021143D7278F5D4A10@MWHPR02MB3326.namprd02.prod.outlook.com>
2018-03-30 17:33 ` Enrico Mioso
[not found] ` <CAOt++SeLh_NxcmM=YEMQSv4y9PabS_dT7k4yTxUiqXbac-=iUQ@mail.gmail.com>
2018-04-17 13:55 ` Enrico Mioso
2018-04-17 13:56 ` Jamie Stuart
2018-04-17 13:57 ` Enrico Mioso
2018-04-17 19:42 ` Stanislaw Gruszka
[not found] ` <CAOt++SeNt=4RUTvAR1y_WjC=a-YyYa3YBSmoAmv+7uK71U+3+A@mail.gmail.com>
2018-05-28 12:50 ` Stanislaw Gruszka
2018-05-28 13:54 ` Daniel Golle
2018-08-15 11:40 ` Stanislaw Gruszka
2018-08-15 22:35 ` Daniel Golle
2018-08-16 11:01 ` Stanislaw Gruszka
[not found] ` <DM5PR02MB365669D5E9F2DE20DAE4CB7AD43E0@DM5PR02MB3656.namprd02.prod.outlook.com>
2018-08-18 16:08 ` Daniel Golle
2018-08-20 12:20 ` Stanislaw Gruszka [this message]
2018-08-24 13:02 ` Stanislaw Gruszka
2018-03-28 18:13 ` Stanislaw Gruszka
2018-03-07 15:47 ` Jamie Stuart
2018-03-07 23:30 ` Enrico Mioso
2018-03-07 23:31 ` Enrico Mioso
2018-03-08 9:39 ` Stanislaw Gruszka
2018-03-08 14:28 ` Enrico Mioso
2018-01-23 13:20 ` Stanislaw Gruszka
2017-12-26 17:20 ` Enrico Mioso
2018-01-03 11:45 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820122041.GA8109@redhat.com \
--to=sgruszka@redhat.com \
--cc=cmatsuura@vivint.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=jamie@onebillion.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=nbd@nbd.name \
--cc=nenekofi@gmail.com \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).