From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Sara Sharon <sara.sharon@intel.com>
Subject: Re: [PATCH] mac80211: avoid kernel panic when building AMSDU from non-linear SKB
Date: Wed, 29 Aug 2018 12:16:38 +0200 [thread overview]
Message-ID: <20180829101637.GA2488@localhost.localdomain> (raw)
In-Reply-To: <20180829065702.7316-1-johannes@sipsolutions.net>
> From: Sara Sharon <sara.sharon@intel.com>
>
> When building building AMSDU from non-linear SKB, we hit a
> kernel panic when trying to push the padding to the tail.
> Instead, put the padding at the head of the next subframe.
> This also fixes the A-MSDU subframes to not have the padding
> accounted in the length field and not have pad at all for
> the last subframe, both required by the spec.
>
> Fixes: 6e0456b54545 ("mac80211: add A-MSDU tx support")
> Signed-off-by: Sara Sharon <sara.sharon@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/mac80211/tx.c | 38 +++++++++++++++++++++-----------------
> 1 file changed, 21 insertions(+), 17 deletions(-)
>
Reviewed-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
prev parent reply other threads:[~2018-08-29 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 6:57 [PATCH] mac80211: avoid kernel panic when building AMSDU from non-linear SKB Johannes Berg
2018-08-29 10:16 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829101637.GA2488@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sara.sharon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).