From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: always account for A-MSDU header changes
Date: Thu, 30 Aug 2018 11:04:06 +0200 [thread overview]
Message-ID: <20180830090406.GD9867@localhost.localdomain> (raw)
In-Reply-To: <20180830085549.21955-1-johannes@sipsolutions.net>
> From: Johannes Berg <johannes.berg@intel.com>
>
> In the error path of changing the SKB headroom of the second
> A-MSDU subframe, we would not account for the already-changed
> length of the first frame that just got converted to be in
> A-MSDU format and thus is a bit longer now.
>
> Fix this by doing the necessary accounting.
>
> It would be possible to reorder the operations, but that would
> make the code more complex (to calculate the necessary pad),
> and the headroom expansion should not fail frequently enough
> to make that worthwhile.
>
> Fixes: 6e0456b54545 ("mac80211: add A-MSDU tx support")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
prev parent reply other threads:[~2018-08-30 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 8:55 [PATCH] mac80211: always account for A-MSDU header changes Johannes Berg
2018-08-30 9:04 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830090406.GD9867@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox