* [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument
@ 2018-08-20 18:48 Larry Finger
2018-08-31 15:46 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2018-08-20 18:48 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger
In gcc8, when the 3rd argument (size) of a call to strncpy() matches the
length of the first argument, the compiler warns of the possibility of an
unterminated string. Using strlcpy() forces a null at the end.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
index c2d5b495c179..c089540116fa 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/leds.c
@@ -146,7 +146,7 @@ static int rtl8187_register_led(struct ieee80211_hw *dev,
led->dev = dev;
led->ledpin = ledpin;
led->is_radio = is_radio;
- strncpy(led->name, name, sizeof(led->name));
+ strlcpy(led->name, name, sizeof(led->name));
led->led_dev.name = led->name;
led->led_dev.default_trigger = default_trigger;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument
2018-08-20 18:48 [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument Larry Finger
@ 2018-08-31 15:46 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-08-31 15:46 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> In gcc8, when the 3rd argument (size) of a call to strncpy() matches the
> length of the first argument, the compiler warns of the possibility of an
> unterminated string. Using strlcpy() forces a null at the end.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-drivers-next.git, thanks.
199ba9faca90 rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument
--
https://patchwork.kernel.org/patch/10570639/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-31 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-20 18:48 [PATCH] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument Larry Finger
2018-08-31 15:46 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).