From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Sid Hayn <sidhayn@gmail.com>
Cc: sgruszka@redhat.com,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@nbd.name>,
linux-mediatek@lists.infradead.org
Subject: Re: mt76x0 bug report
Date: Fri, 7 Sep 2018 10:24:13 +0200 [thread overview]
Message-ID: <20180907082413.GC2725@localhost.localdomain> (raw)
In-Reply-To: <CAM0KTbAF_ztZzFk_iECyPbiWY69xrcdT_93ypnuTzocjX_fRuQ@mail.gmail.com>
> Actions like that have caused great problems in the past, as the
> kernel won't allow channel control of a monitor interface at all when
> there is a managed interface on the same phy (afaik).
>
> But just for fun and codepath testing here are two test scenarios:
>
> Test 1: "iwconfig t2u mode monitor"
> Sees nothing on any channel, no packets reported
>
> Test 2(requested test): "iw phy phy11 interface add t2uhmon type monitor"
> Sees nothing on any channel, no packets reported.
> Despite having a monitor and managed interface on the same phy,
> iwconfig is reporting that the channel is changing as requested. So
> perhaps my above "afaik" comment is partially outdated.
>
> For both tests the interface was not used to connect to any ap prior
> to or during testing.
>
Could you please try following patch?
Regards,
Lorenzo
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
@@ -756,11 +756,10 @@ __mt76x0_phy_set_channel(struct mt76x0_dev *dev,
/* Vendor driver don't do it */
/* mt76x0_phy_set_tx_power(dev, channel, rf_bw_band); */
+ mt76x0_vco_cal(dev, channel);
if (scan)
- mt76x0_vco_cal(dev, channel);
-
- mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
+ mt76x0_mcu_calibrate(dev, MCU_CAL_RXDCOC, 1);
mt76x0_phy_set_chan_pwr(dev, channel);
dev->mt76.chandef = *chandef;
next prev parent reply other threads:[~2018-09-07 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 17:33 mt76x0 bug report Sid Hayn
2018-09-04 21:04 ` Lorenzo Bianconi
2018-09-05 20:52 ` Sid Hayn
2018-09-06 9:32 ` Stanislaw Gruszka
2018-09-06 15:39 ` Sid Hayn
2018-09-06 15:42 ` Lorenzo Bianconi
2018-09-06 15:53 ` Sid Hayn
2018-09-07 8:24 ` Lorenzo Bianconi [this message]
2018-09-07 19:55 ` Sid Hayn
2018-09-14 15:32 ` Sid Hayn
2018-09-14 15:42 ` Davide Caratti
2018-09-14 15:47 ` Lorenzo Bianconi
2018-09-14 15:51 ` Sid Hayn
2018-09-18 3:18 ` Sid Hayn
2018-09-18 11:56 ` Stanislaw Gruszka
2018-09-18 17:36 ` Sid Hayn
2018-09-19 11:15 ` Stanislaw Gruszka
2018-09-19 18:01 ` Sid Hayn
2018-09-06 16:51 ` Sid Hayn
2018-09-06 17:13 ` Lorenzo Bianconi
2018-09-06 22:37 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907082413.GC2725@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
--cc=sidhayn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).