* [PATCH] brcmsmac: Use kvmalloc() for ucode allocations
@ 2018-09-13 6:15 Takashi Iwai
2018-09-20 12:11 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2018-09-13 6:15 UTC (permalink / raw)
To: Arend van Spriel
Cc: Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Kalle Valo, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list
The ucode chunk might be relatively large and the allocation with
kmalloc() may fail occasionally. Since the data isn't DMA-transferred
but by manual loops, we can use vmalloc instead of kmalloc.
For a better performance, though, kvmalloc() would be the best choice
in such a case, so let's replace with it.
Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1103431
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
.../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
index ecc89e718b9c..6255fb6d97a7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
@@ -1578,10 +1578,10 @@ int brcms_ucode_init_buf(struct brcms_info *wl, void **pbuf, u32 idx)
if (le32_to_cpu(hdr->idx) == idx) {
pdata = wl->fw.fw_bin[i]->data +
le32_to_cpu(hdr->offset);
- *pbuf = kmemdup(pdata, len, GFP_KERNEL);
+ *pbuf = kvmalloc(len, GFP_KERNEL);
if (*pbuf == NULL)
goto fail;
-
+ memcpy(*pbuf, pdata, len);
return 0;
}
}
@@ -1629,7 +1629,7 @@ int brcms_ucode_init_uint(struct brcms_info *wl, size_t *n_bytes, u32 idx)
*/
void brcms_ucode_free_buf(void *p)
{
- kfree(p);
+ kvfree(p);
}
/*
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] brcmsmac: Use kvmalloc() for ucode allocations
2018-09-13 6:15 [PATCH] brcmsmac: Use kvmalloc() for ucode allocations Takashi Iwai
@ 2018-09-20 12:11 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-09-20 12:11 UTC (permalink / raw)
To: Takashi Iwai
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list
Takashi Iwai <tiwai@suse.de> wrote:
> The ucode chunk might be relatively large and the allocation with
> kmalloc() may fail occasionally. Since the data isn't DMA-transferred
> but by manual loops, we can use vmalloc instead of kmalloc.
> For a better performance, though, kvmalloc() would be the best choice
> in such a case, so let's replace with it.
>
> Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1103431
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Patch applied to wireless-drivers-next.git, thanks.
6c3efbe77bc7 brcmsmac: Use kvmalloc() for ucode allocations
--
https://patchwork.kernel.org/patch/10598731/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-20 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-13 6:15 [PATCH] brcmsmac: Use kvmalloc() for ucode allocations Takashi Iwai
2018-09-20 12:11 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).