From: Ajay Singh <ajay.kathat@microchip.com>
To: Joe Perches <joe@perches.com>
Cc: <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<gregkh@linuxfoundation.org>, <ganesh.krishna@microchip.com>,
<aditya.shankar@microchip.com>, <venkateswara.kaja@microchip.com>,
<claudiu.beznea@microchip.com>, <adham.abozaeid@microchip.com>
Subject: Re: [PATCH v2 28/29] staging: wilc1000: avoid spaces preferred around checkpatch issue
Date: Thu, 20 Sep 2018 16:51:55 +0530 [thread overview]
Message-ID: <20180920165155.08f72ea0@ajaysk-VirtualBox> (raw)
In-Reply-To: <6e925b2021d5fbc59f1933d37a1deb1332ede752.camel@perches.com>
On Thu, 20 Sep 2018 02:57:21 -0700
Joe Perches <joe@perches.com> wrote:
> On Thu, 2018-09-20 at 11:53 +0530, Ajay Singh wrote:
> > Cleanup patch to add extra spaces around the '/' to avoid the below
> > checkpatch warning.
> >
> > 'spaces preferred around that '/' (ctx:VxV)'
> >
> > Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> > ---
> > drivers/staging/wilc1000/linux_wlan.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wilc1000/linux_wlan.c
> > b/drivers/staging/wilc1000/linux_wlan.c index 695d5b2..29c1317
> > 100644 --- a/drivers/staging/wilc1000/linux_wlan.c
> > +++ b/drivers/staging/wilc1000/linux_wlan.c
> > @@ -823,7 +823,7 @@ static void wilc_set_multicast_list(struct
> > net_device *dev)
> > netdev_for_each_mc_addr(ha, dev) {
> > memcpy(mc_list + i, ha->addr, ETH_ALEN);
> > - netdev_dbg(dev, "Entry[%d]: %x:%x:%x:%x:%x:%x\n",
> > i/ETH_ALEN,
> > + netdev_dbg(dev, "Entry[%d]: %x:%x:%x:%x:%x:%x\n",
> > i / ETH_ALEN, mc_list[i], mc_list[i + 1], mc_list[i + 2],
> > mc_list[i + 3], mc_list[i + 4],
> > mc_list[i + 5]); i += ETH_ALEN;
>
> Probably better using the vsprintf %pM extension:
>
> netdev_dbg(dev, Entry[%d]: %pM\n", i / ETH_ALEN, mc_list + i);
>
> though I would also suggest using another temporary
> pointer instead of an offset and divisions.
>
> Something like:
>
> o use kmalloc_array
> o remove unnecessary res
> o add u8 *cur_mc
> o use i as index
Hi Joe,
Thanks for your suggestion and sharing the code changes.
I agree, it looks better with your modification.
Do I need to resend the updated patch series by including your
changes or can this patch be applied from your mail ?
Regards,
Ajay
next prev parent reply other threads:[~2018-09-20 17:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 6:23 [PATCH v2 00/29] staging: wilc1000: avoid static variables and cleanup changes Ajay Singh
2018-09-20 6:23 ` [PATCH v2 01/29] staging: wilc1000: change return type to 'void' for wilc_frame_register() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 02/29] staging: wilc1000: change return type to 'void' for wilc_wlan_set_bssid() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 03/29] staging: wilc1000: change return type to 'void' for lock init & deinit functions Ajay Singh
2018-09-20 6:23 ` [PATCH v2 04/29] staging: wilc1000: change return type to 'void' for wilc_deinit_host_int() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 05/29] staging: wilc1000: change return type to 'void' for wilc_wfi_deinit_mon_interface() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 06/29] staging: wilc1000: use 'void' return type for host_int_get_assoc_res_info() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 07/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_add_to_head() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 08/29] staging: wilc1000: change return type to 'void' tcp ack filter functions Ajay Singh
2018-09-20 6:23 ` [PATCH v2 09/29] staging: wilc1000: use 'void' return for wilc_wlan_txq_filter_dup_tcp_ack() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 10/29] staging: wilc1000: change return type to 'void' for wilc_wlan_cfg_indicate_rx() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 11/29] staging: wilc1000: refactor wilc_wlan_parse_info_frame() function Ajay Singh
2018-09-20 6:23 ` [PATCH v2 12/29] staging: wilc1000: set default value of cfg response type in wilc_wlan_cfg_indicate_rx() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 13/29] staging: wilc1000: changes 'val' type to u8 in wilc_cfg_byte struct Ajay Singh
2018-09-20 6:23 ` [PATCH v2 14/29] staging: wilc1000: remove unused wid type values Ajay Singh
2018-09-20 6:23 ` [PATCH v2 15/29] staging: wilc1000: remove unused wid from cfg struct Ajay Singh
2018-09-20 6:23 ` [PATCH v2 16/29] staging: wilc1000: refactor code to remove 'mac_status' from 'wilc_mac_cfg' struct Ajay Singh
2018-09-20 6:23 ` [PATCH v2 17/29] staging: wilc1000: refactor code to avoid static variables for config parameters Ajay Singh
2018-09-20 6:23 ` [PATCH v2 18/29] staging: wilc1000: rename 'wilc_mac_cfg' struct to 'wilc_cfg_str_vals' Ajay Singh
2018-09-20 6:23 ` [PATCH v2 19/29] staging: wilc1000: avoid the use of 'hif_driver_comp' completion variable Ajay Singh
2018-09-20 6:23 ` [PATCH v2 20/29] staging: wilc1000: remove use of unnecessary 'wilc_connected_ssid' variable Ajay Singh
2018-09-20 6:23 ` [PATCH v2 21/29] staging: wilc1000: avoid use of 'g_sdio' static variable Ajay Singh
2018-09-20 6:23 ` [PATCH v2 22/29] staging: wilc1000: avoid use of 'g_spi' " Ajay Singh
2018-09-20 6:23 ` [PATCH v2 23/29] staging: wilc1000: remove unnecessary memset in sdio_init() & wilc_spi_init() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 24/29] staging: wilc1000: remove p2p related static variables to wilc_vif struct Ajay Singh
2018-09-20 6:23 ` [PATCH v2 25/29] staging: wilc1000: remove wilc_debugfs.c file as its not used Ajay Singh
2018-09-20 6:23 ` [PATCH v2 26/29] staging: wilc1000: remove unnecessary option used with ccflags-y in Makefile Ajay Singh
2018-09-20 6:23 ` [PATCH v2 27/29] staging: wilc1000: use usleep_range() in place of udelay() Ajay Singh
2018-09-20 6:23 ` [PATCH v2 28/29] staging: wilc1000: avoid spaces preferred around checkpatch issue Ajay Singh
2018-09-20 9:57 ` Joe Perches
2018-09-20 11:21 ` Ajay Singh [this message]
2018-09-20 6:23 ` [PATCH v2 29/29] staging: wilc1000: return exact error of register_netdev() from wilc_netdev_init() Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920165155.08f72ea0@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).