From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>,
linux-wireless@vger.kernel.org, Sid Hayn <sidhayn@gmail.com>
Subject: Re: [PATCH] mt76x0: add quirk to disable 2.4GHz band for Archer T1U
Date: Tue, 25 Sep 2018 11:48:37 +0200 [thread overview]
Message-ID: <20180925094837.GD2029@redhat.com> (raw)
In-Reply-To: <20180925090746.GC3872@localhost.localdomain>
On Tue, Sep 25, 2018 at 11:07:47AM +0200, Lorenzo Bianconi wrote:
> On Sep 25, Felix Fietkau wrote:
> > On 2018-09-25 09:54, Lorenzo Bianconi wrote:
> > >>
> > >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > >> index 76d607f73758..b7a1069ecd0e 100644
> > >> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > >> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > >> @@ -45,7 +45,8 @@
> > >> { USB_DEVICE(0x20f4, 0x806b) }, /* TRENDnet TEW-806UBH */
> > >> { USB_DEVICE(0x7392, 0xc711) }, /* Devolo Wifi ac Stick */
> > >> { USB_DEVICE(0x0df6, 0x0079) }, /* Sitecom Europe B.V. ac Stick */
> > >> - { USB_DEVICE(0x2357, 0x0105) }, /* TP-LINK Archer T1U */
> > >> + { USB_DEVICE(0x2357, 0x0105),
> > >> + .driver_info = 1, }, /* TP-LINK Archer T1U */
> > >
> > > Hi Stanislaw,
> > >
> > > what about using 'ieee80211-freq-limit' OF property to limit available wireless
> > > band? In this way we can take into account even the opposite case (no 5GHz).
> > That doesn't make sense for USB devices, which can be plugged into any
> > machine.
>
> Ack, right.
> What about a more general solution like adding an enum { NO_5GHz = 1, NO_2GHz }?
> Does it worth to implement it now?
I do not see reason for that. Basically band information should be
read from EEPROM, I do not expect need for more quirks like this.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-09-25 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 6:49 [PATCH] mt76x0: add quirk to disable 2.4GHz band for Archer T1U Stanislaw Gruszka
2018-09-25 7:54 ` Lorenzo Bianconi
2018-09-25 8:00 ` Felix Fietkau
2018-09-25 9:07 ` Lorenzo Bianconi
2018-09-25 9:48 ` Stanislaw Gruszka [this message]
2018-09-25 9:55 ` Arend van Spriel
2018-09-25 10:01 ` Stanislaw Gruszka
2018-09-26 15:42 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925094837.GD2029@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=sidhayn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).