From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/4] mt76x0: print BBP version only for debug
Date: Thu, 27 Sep 2018 11:37:14 +0200 [thread overview]
Message-ID: <20180927093713.GA20538@redhat.com> (raw)
In-Reply-To: <20180927092629.GA2489@localhost.localdomain>
On Thu, Sep 27, 2018 at 11:26:30AM +0200, Lorenzo Bianconi wrote:
> > Use dev_dbg to print BBP version.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > index 4fd2c65e196a..ca0a693654a3 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > @@ -187,7 +187,6 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
> >
> > do {
> > val = mt76_rr(dev, MT_BBP(CORE, 0));
> > - printk("BBP version %08x\n", val);
> > if (val && ~val)
> > break;
> > } while (--i);
> > @@ -197,6 +196,7 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
> > return -EIO;
> > }
> >
> > + dev_dbg(dev->mt76.dev, "BBP version %08x\n", val);
> > return 0;
> > }
>
> I guess we can drop mt76x0_wait_bbp_ready and use mt76x02_wait_for_mac instead
Why? Wait for BBP is diffrent, we read MT_BBP(CORE, 0)=0x2000 register,
wait for MAC we read MT_MAC_CSR0=0x1000 ?
Baside this patch is about replacing printk by dev_dbg.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-09-27 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 8:37 [RFC 0/4] mt76x0: phy/rf fixups for PCIe Stanislaw Gruszka
2018-09-27 8:37 ` [RFC 1/4] mt76x0: print BBP version only for debug Stanislaw Gruszka
2018-09-27 9:26 ` Lorenzo Bianconi
2018-09-27 9:34 ` Lorenzo Bianconi
2018-09-27 9:41 ` Stanislaw Gruszka
2018-09-27 9:37 ` Stanislaw Gruszka [this message]
2018-09-27 8:37 ` [RFC 2/4] mt76x0: correct RF access via RF_CSR regiser Stanislaw Gruszka
2018-09-27 8:37 ` [RFC 3/4] mt76: allow to identify bus Stanislaw Gruszka
2018-09-27 8:37 ` [RFC 4/4] mt76x0: correct RF reg pairs write for PCIe Stanislaw Gruszka
2018-09-27 11:47 ` [RFC 0/4] mt76x0: phy/rf fixups " Felix Fietkau
2018-09-30 19:11 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927093713.GA20538@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).