From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 19/26] mt76x0: pci: add hw initialization at bootstrap
Date: Thu, 27 Sep 2018 17:18:15 +0200 [thread overview]
Message-ID: <20180927151814.GF24450@localhost.localdomain> (raw)
In-Reply-To: <20180927102440.GE19941@redhat.com>
> On Thu, Sep 27, 2018 at 11:01:48AM +0200, Lorenzo Bianconi wrote:
> > Add mt76x0e_register_device routine in pci_init.c
> > to initialize the device during hw probe.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > ---
> > .../wireless/mediatek/mt76/mt76x0/Makefile | 2 +-
> > .../net/wireless/mediatek/mt76/mt76x0/init.c | 10 +--
> > .../wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 +
> > .../net/wireless/mediatek/mt76/mt76x0/pci.c | 2 +-
> > .../wireless/mediatek/mt76/mt76x0/pci_init.c | 65 +++++++++++++++++++
> > .../wireless/mediatek/mt76/mt76x02_eeprom.h | 1 +
> > 6 files changed, 73 insertions(+), 9 deletions(-)
> > create mode 100644 drivers/net/wireless/mediatek/mt76/mt76x0/pci_init.c
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > index 30c84a557076..daa4929bdee6 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/Makefile
> > @@ -6,7 +6,7 @@ mt76x0-common-y := \
> > init.o main.o trace.o eeprom.o phy.o \
> > mac.o debugfs.o tx.o
> > mt76x0u-y := usb.o usb_mcu.o usb_init.o
> > -mt76x0e-y := pci.o pci_mcu.o
> > +mt76x0e-y := pci.o pci_mcu.o pci_init.o
>
> How much {pci,usb}_{init,mcu}.c files are expected to grow?
> For now they are about between 100 and 200 lines of code
> and I do not see reason to move code into separate files
> so far. It could be easy placed in usb.c and pci.c files.
> But if the files will grow, I'm ok with code moving.
At the moment I do not know how much {pci,usb}_{init,mcu}.c will
grow, I guess a little bit more. Anyway I would prefer to have
in {pci/usb}.c just bus specific code (but it is a matter of taste
actually)
Regards,
Lorenzo
>
> Thanks
> Stanislaw
next prev parent reply other threads:[~2018-09-27 15:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 9:01 [PATCH 00/26] add mt76x0e hw initialization support Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 01/26] mt76x0: use mt76_poll in mt76x0_set_wlan_state Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 02/26] mt76: move wait_for_wpdma in mt76x02_dma.h Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 03/26] mt76: add mt76x02_dma_enable/mt76x02_dma_disable utility routines Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 04/26] mt76: move mt76x02_set_irq_mask in mt76x02_core.c Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 05/26] mt76: move queue initialization in mt76x02_dma.c Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 06/26] mt76: move mt76x02_beacon_offset in mt76x02_core.c Lorenzo Bianconi
2018-09-27 10:06 ` Stanislaw Gruszka
2018-09-27 15:14 ` Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 07/26] mt76: mmio: add implementation of wr_rp and rd_rp Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 08/26] mt76: move mt76x2_wait_for_bbp in mt76x02-lib module Lorenzo Bianconi
2018-09-27 10:10 ` Stanislaw Gruszka
2018-09-27 15:15 ` Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 09/26] mt76x0: update initvals to latest version of vendor driver Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 10/26] mt76x0: pci: move mcu code in pci_mcu.c Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 11/26] mt76x0: usb: move mcu code in usb_mcu.c Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 12/26] mt76x0: use mt76x02 utility routines in mt76x0 init code Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 13/26] mt76x0: init: remove duplicated initialization Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 14/26] mt76x0: init: remove MT_PBF_SYS_CTRL configuration in mt76x0_reset_csr_bbp Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 15/26] mt76x0: init: reset beacon offset during bootstrap Lorenzo Bianconi
2018-09-27 10:14 ` Stanislaw Gruszka
2018-09-27 15:12 ` Lorenzo Bianconi
2018-09-27 10:15 ` Felix Fietkau
2018-09-27 15:12 ` Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 16/26] mt76x0: init rx filter in mt76x0_init_hardware Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 17/26] mt76: add mt76x02_mac_start routine Lorenzo Bianconi
2018-09-27 10:17 ` Stanislaw Gruszka
2018-09-27 15:10 ` Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 18/26] mt76x0: usb: move initialization code in usb_init.c Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 19/26] mt76x0: pci: add hw initialization at bootstrap Lorenzo Bianconi
2018-09-27 10:24 ` Stanislaw Gruszka
2018-09-27 15:18 ` Lorenzo Bianconi [this message]
2018-09-27 9:01 ` [PATCH 20/26] mt76x0: phy: set antenna parameter according to wireless band Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 21/26] mt76: move set_{tx,rx}_path routines in mt76x02-lib module Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 22/26] mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 23/26] mt76x0: pci: add mt76x0e_start callback Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 24/26] mt76x0: pci: add mt76x0e_stop callback Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 25/26] mt76: move eeprom_load routines in mt76x02_eeprom.c Lorenzo Bianconi
2018-09-27 10:30 ` Felix Fietkau
2018-09-27 14:46 ` Lorenzo Bianconi
2018-09-27 9:01 ` [PATCH 26/26] mt76x0: introduce mt76x0{e,u}_eeprom_init routines Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927151814.GF24450@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).