* [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
@ 2018-10-01 9:04 pkshih
2018-10-01 9:10 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: pkshih @ 2018-10-01 9:04 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, joe, rickveens92, Larry.Finger
From: Rick Veens <rickveens92@gmail.com>
The following:
bool efuse_re_pg_sec1flag;
u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.
This patch is originally created by Rick Veens <rickveens92@gmail.com>,
and Joe Perches <joe@perches.com> reminded to apply it to rtlwifi.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtlwifi/wifi.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h
index 0f3b98c5227f..87bc21bb5e8b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
+++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
@@ -1905,10 +1905,6 @@ struct rtl_efuse {
u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
u16 efuse_usedbytes;
u8 efuse_usedpercentage;
-#ifdef EFUSE_REPG_WORKAROUND
- bool efuse_re_pg_sec1flag;
- u8 efuse_re_pg_data[8];
-#endif
u8 autoload_failflag;
u8 autoload_status;
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
2018-10-01 9:04 [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h pkshih
@ 2018-10-01 9:10 ` Kalle Valo
2018-10-01 9:24 ` Pkshih
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2018-10-01 9:10 UTC (permalink / raw)
To: pkshih; +Cc: linux-wireless, joe, rickveens92, Larry.Finger
<pkshih@realtek.com> writes:
> From: Rick Veens <rickveens92@gmail.com>
>
> The following:
> bool efuse_re_pg_sec1flag;
> u8 efuse_re_pg_data[8];
> are not referenced anywhere in the rtlwifi code.
>
> This patch is originally created by Rick Veens <rickveens92@gmail.com>,
> and Joe Perches <joe@perches.com> reminded to apply it to rtlwifi.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Rick's Signed-off-by is missing. Ping, either you need to mark yourself
as author (which IMHO is correct as you wrote this patch anyway, Rick
wrote it for the other driver) or Rick needs to give his s-o-b.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
2018-10-01 9:10 ` Kalle Valo
@ 2018-10-01 9:24 ` Pkshih
0 siblings, 0 replies; 3+ messages in thread
From: Pkshih @ 2018-10-01 9:24 UTC (permalink / raw)
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, joe@perches.com,
Larry.Finger@lwfinger.net, rickveens92@gmail.com
On Mon, 2018-10-01 at 12:10 +0300, Kalle Valo wrote:
> <pkshih@realtek.com> writes:
>
> > From: Rick Veens <rickveens92@gmail.com>
> >
> > The following:
> > bool efuse_re_pg_sec1flag;
> > u8 efuse_re_pg_data[8];
> > are not referenced anywhere in the rtlwifi code.
> >
> > This patch is originally created by Rick Veens <rickveens92@gmail.com>,
> > and Joe Perches <joe@perches.com> reminded to apply it to rtlwifi.
> >
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Rick's Signed-off-by is missing. Ping, either you need to mark yourself
> as author (which IMHO is correct as you wrote this patch anyway, Rick
> wrote it for the other driver) or Rick needs to give his s-o-b.
>
Will send v2.
Thanks
--
PK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-01 9:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-01 9:04 [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h pkshih
2018-10-01 9:10 ` Kalle Valo
2018-10-01 9:24 ` Pkshih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).