From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76x0: init: intrduce MT_H2M_* definitions
Date: Mon, 1 Oct 2018 11:19:40 +0200 [thread overview]
Message-ID: <20181001091939.GB3055@localhost.localdomain> (raw)
In-Reply-To: <20181001054355.GB22206@redhat.com>
> On Sat, Sep 29, 2018 at 07:30:32PM +0200, Lorenzo Bianconi wrote:
> > Add MT_H2M_BBP_AGENT, MT_H2M_MAILBOX_CSR and MT_H2M_INT_SRC and
> > remove magic numbers
> >
> >
> > /* TODO: Probably not needed */
> > - mt76_wr(dev, 0x7028, 0);
> > - mt76_wr(dev, 0x7010, 0);
> > - mt76_wr(dev, 0x7024, 0);
> > - msleep(10);
> > + mt76_wr(dev, MT_H2M_BBP_AGENT, 0);
> > + mt76_wr(dev, MT_H2M_MAILBOX_CSR, 0);
> > + mt76_wr(dev, MT_H2M_INT_SRC, 0);
>
> The same here, I think this should be just removed.
ack, will send a patch to remove them
>
> > + usleep_range(10000, 20000);
>
> Why this change ?
afaik for sleeping less than 20ms it is better to use usleep_range
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/timers/timers-howto.txt
Regards,
Lorenzo
>
> Thanks
> Stanislaw
prev parent reply other threads:[~2018-10-01 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 17:30 [PATCH] mt76x0: init: intrduce MT_H2M_* definitions Lorenzo Bianconi
2018-10-01 5:43 ` Stanislaw Gruszka
2018-10-01 9:19 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001091939.GB3055@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).