From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 02/10] mt76: move mt76x02_rx_get_sta and mt76x02_rx_get_sta_wcid in mt76x02_util.c
Date: Tue, 2 Oct 2018 10:20:59 +0200 [thread overview]
Message-ID: <20181002082058.GA3156@localhost.localdomain> (raw)
In-Reply-To: <97478608-a454-7bc0-8478-e4a8e87ac7b0@nbd.name>
> > EXPORT_SYMBOL_GPL(mt76x02_set_beacon_offsets);
> >
> > +struct mt76x02_sta *
> > +mt76x02_rx_get_sta(struct mt76_dev *dev, u8 idx)
> > +{
> > + struct mt76_wcid *wcid;
> > +
> > + if (idx >= ARRAY_SIZE(dev->wcid))
> > + return NULL;
> > +
> > + wcid = rcu_dereference(dev->wcid[idx]);
> > + if (!wcid)
> > + return NULL;
> > +
> > + return container_of(wcid, struct mt76x02_sta, wcid);
> > +}
> > +EXPORT_SYMBOL_GPL(mt76x02_rx_get_sta);
> > +
> > +struct mt76_wcid *
> > +mt76x02_rx_get_sta_wcid(struct mt76x02_sta *sta, bool unicast)
> > +{
> > + if (!sta)
> > + return NULL;
> > +
> > + if (unicast)
> > + return &sta->wcid;
> > + else
> > + return &sta->vif->group_wcid;
> > +}
> > +EXPORT_SYMBOL_GPL(mt76x02_rx_get_sta_wcid);
> Both of these functions are trivial and should be inline.
ack, will do in v2.
Regards,
Lorenzo
>
> - Felix
prev parent reply other threads:[~2018-10-02 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 22:19 [PATCH 02/10] mt76: move mt76x02_rx_get_sta and mt76x02_rx_get_sta_wcid in mt76x02_util.c Lorenzo Bianconi
2018-10-02 5:27 ` Felix Fietkau
2018-10-02 8:20 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002082058.GA3156@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox