* new mt76 usb crashes on device removal
@ 2018-10-03 8:23 Stanislaw Gruszka
2018-10-03 9:15 ` Lorenzo Bianconi
0 siblings, 1 reply; 7+ messages in thread
From: Stanislaw Gruszka @ 2018-10-03 8:23 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
After
b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
I have new crashs when remove mt76x0u and mt76x2u devices.
I can not provide calltrace because some other warning/traces
show up instantly after the problem happen and mask prints
for initall problem. Then the machine hungs.
Anyway bisection blame b11e19694dc9 commit and I confirm that problem
not happen before this commit. I also applied the fix with I just
posted, so this is diffrent issue.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 8:23 new mt76 usb crashes on device removal Stanislaw Gruszka
@ 2018-10-03 9:15 ` Lorenzo Bianconi
2018-10-03 10:29 ` Stanislaw Gruszka
0 siblings, 1 reply; 7+ messages in thread
From: Lorenzo Bianconi @ 2018-10-03 9:15 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: nbd, linux-wireless
> After
>
> b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
>
> I have new crashs when remove mt76x0u and mt76x2u devices.
> I can not provide calltrace because some other warning/traces
> show up instantly after the problem happen and mask prints
> for initall problem. Then the machine hungs.
>
> Anyway bisection blame b11e19694dc9 commit and I confirm that problem
> not happen before this commit. I also applied the fix with I just
> posted, so this is diffrent issue.
Hi Stanislaw,
I do not know if it is related or not, but could you please try following patch:
Regards,
Lorenzo
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
@@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev *dev)
struct ieee80211_hw *hw = dev->mt76.hw;
int err;
- err = mt76u_mcu_init_rx(&dev->mt76);
+ err = mt76u_alloc_queues(&dev->mt76);
if (err < 0)
return err;
- err = mt76u_alloc_queues(&dev->mt76);
+ err = mt76u_mcu_init_rx(&dev->mt76);
if (err < 0)
return err;
>
> Thanks
> Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 9:15 ` Lorenzo Bianconi
@ 2018-10-03 10:29 ` Stanislaw Gruszka
2018-10-03 10:32 ` Lorenzo Bianconi
2018-10-03 14:09 ` Lorenzo Bianconi
0 siblings, 2 replies; 7+ messages in thread
From: Stanislaw Gruszka @ 2018-10-03 10:29 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote:
> > After
> >
> > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
> >
> > I have new crashs when remove mt76x0u and mt76x2u devices.
> > I can not provide calltrace because some other warning/traces
> > show up instantly after the problem happen and mask prints
> > for initall problem. Then the machine hungs.
> >
> > Anyway bisection blame b11e19694dc9 commit and I confirm that problem
> > not happen before this commit. I also applied the fix with I just
> > posted, so this is diffrent issue.
>
> Hi Stanislaw,
>
> I do not know if it is related or not, but could you please try following patch:
>
> Regards,
> Lorenzo
>
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> @@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev *dev)
> struct ieee80211_hw *hw = dev->mt76.hw;
> int err;
>
> - err = mt76u_mcu_init_rx(&dev->mt76);
> + err = mt76u_alloc_queues(&dev->mt76);
> if (err < 0)
> return err;
>
> - err = mt76u_alloc_queues(&dev->mt76);
> + err = mt76u_mcu_init_rx(&dev->mt76);
> if (err < 0)
> return err;
It still crashes. You can not reproduce the problem ?
It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 10:29 ` Stanislaw Gruszka
@ 2018-10-03 10:32 ` Lorenzo Bianconi
2018-10-03 14:09 ` Lorenzo Bianconi
1 sibling, 0 replies; 7+ messages in thread
From: Lorenzo Bianconi @ 2018-10-03 10:32 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: nbd, linux-wireless
On Oct 03, Stanislaw Gruszka wrote:
> On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote:
> > > After
> > >
> > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
> > >
> > > I have new crashs when remove mt76x0u and mt76x2u devices.
> > > I can not provide calltrace because some other warning/traces
> > > show up instantly after the problem happen and mask prints
> > > for initall problem. Then the machine hungs.
> > >
> > > Anyway bisection blame b11e19694dc9 commit and I confirm that problem
> > > not happen before this commit. I also applied the fix with I just
> > > posted, so this is diffrent issue.
> >
> > Hi Stanislaw,
> >
> > I do not know if it is related or not, but could you please try following patch:
> >
> > Regards,
> > Lorenzo
> >
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > @@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev *dev)
> > struct ieee80211_hw *hw = dev->mt76.hw;
> > int err;
> >
> > - err = mt76u_mcu_init_rx(&dev->mt76);
> > + err = mt76u_alloc_queues(&dev->mt76);
> > if (err < 0)
> > return err;
> >
> > - err = mt76u_alloc_queues(&dev->mt76);
> > + err = mt76u_mcu_init_rx(&dev->mt76);
> > if (err < 0)
> > return err;
>
> It still crashes. You can not reproduce the problem ?
> It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device.
I think I get it, I will send you a series to test. Thanks
Regards,
Lorenzo
>
> Thanks
> Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 10:29 ` Stanislaw Gruszka
2018-10-03 10:32 ` Lorenzo Bianconi
@ 2018-10-03 14:09 ` Lorenzo Bianconi
2018-10-03 14:23 ` Stanislaw Gruszka
1 sibling, 1 reply; 7+ messages in thread
From: Lorenzo Bianconi @ 2018-10-03 14:09 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: nbd, linux-wireless
> On Wed, Oct 03, 2018 at 11:15:37AM +0200, Lorenzo Bianconi wrote:
> > > After
> > >
> > > b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
> > >
> > > I have new crashs when remove mt76x0u and mt76x2u devices.
> > > I can not provide calltrace because some other warning/traces
> > > show up instantly after the problem happen and mask prints
> > > for initall problem. Then the machine hungs.
> > >
> > > Anyway bisection blame b11e19694dc9 commit and I confirm that problem
> > > not happen before this commit. I also applied the fix with I just
> > > posted, so this is diffrent issue.
> >
> > Hi Stanislaw,
> >
> > I do not know if it is related or not, but could you please try following patch:
> >
> > Regards,
> > Lorenzo
> >
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
> > @@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev *dev)
> > struct ieee80211_hw *hw = dev->mt76.hw;
> > int err;
> >
> > - err = mt76u_mcu_init_rx(&dev->mt76);
> > + err = mt76u_alloc_queues(&dev->mt76);
> > if (err < 0)
> > return err;
> >
> > - err = mt76u_alloc_queues(&dev->mt76);
> > + err = mt76u_mcu_init_rx(&dev->mt76);
> > if (err < 0)
> > return err;
>
> It still crashes. You can not reproduce the problem ?
> It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device.
Hi Stanislaw,
any news about the latest patchset I sent to fix that issue?
Regards,
Lorenzo
>
> Thanks
> Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 14:09 ` Lorenzo Bianconi
@ 2018-10-03 14:23 ` Stanislaw Gruszka
2018-10-03 14:32 ` Lorenzo Bianconi
0 siblings, 1 reply; 7+ messages in thread
From: Stanislaw Gruszka @ 2018-10-03 14:23 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless
On Wed, Oct 03, 2018 at 04:09:06PM +0200, Lorenzo Bianconi wrote:
> > It still crashes. You can not reproduce the problem ?
> > It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device.
>
> Hi Stanislaw,
>
> any news about the latest patchset I sent to fix that issue?
It fixed the problem, I thought you tested that by yourself.
Regards
Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: new mt76 usb crashes on device removal
2018-10-03 14:23 ` Stanislaw Gruszka
@ 2018-10-03 14:32 ` Lorenzo Bianconi
0 siblings, 0 replies; 7+ messages in thread
From: Lorenzo Bianconi @ 2018-10-03 14:32 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Felix Fietkau, linux-wireless
>
> On Wed, Oct 03, 2018 at 04:09:06PM +0200, Lorenzo Bianconi wrote:
> > > It still crashes. You can not reproduce the problem ?
> > > It's 100% reproducible for me, when I unplug mt76x0u or mt76x2 device.
> >
> > Hi Stanislaw,
> >
> > any news about the latest patchset I sent to fix that issue?
>
> It fixed the problem, I thought you tested that by yourself.
Yes, I did. I would like to have even a confirmation from you. Thanks.
Regards,
Lorenzo
>
> Regards
> Stanislaw
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-03 14:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-03 8:23 new mt76 usb crashes on device removal Stanislaw Gruszka
2018-10-03 9:15 ` Lorenzo Bianconi
2018-10-03 10:29 ` Stanislaw Gruszka
2018-10-03 10:32 ` Lorenzo Bianconi
2018-10-03 14:09 ` Lorenzo Bianconi
2018-10-03 14:23 ` Stanislaw Gruszka
2018-10-03 14:32 ` Lorenzo Bianconi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).