From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: new mt76 usb crashes on device removal
Date: Wed, 3 Oct 2018 11:15:37 +0200 [thread overview]
Message-ID: <20181003091536.GB27279@localhost.localdomain> (raw)
In-Reply-To: <20181003082309.GB2229@redhat.com>
> After
>
> b11e19694dc9 "mt76x0: add ieee80211_ops ops pointer to mt76x0_alloc_device signature"
>
> I have new crashs when remove mt76x0u and mt76x2u devices.
> I can not provide calltrace because some other warning/traces
> show up instantly after the problem happen and mask prints
> for initall problem. Then the machine hungs.
>
> Anyway bisection blame b11e19694dc9 commit and I confirm that problem
> not happen before this commit. I also applied the fix with I just
> posted, so this is diffrent issue.
Hi Stanislaw,
I do not know if it is related or not, but could you please try following patch:
Regards,
Lorenzo
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c
@@ -179,11 +179,11 @@ static int mt76x0u_register_device(struct mt76x0_dev *dev)
struct ieee80211_hw *hw = dev->mt76.hw;
int err;
- err = mt76u_mcu_init_rx(&dev->mt76);
+ err = mt76u_alloc_queues(&dev->mt76);
if (err < 0)
return err;
- err = mt76u_alloc_queues(&dev->mt76);
+ err = mt76u_mcu_init_rx(&dev->mt76);
if (err < 0)
return err;
>
> Thanks
> Stanislaw
next prev parent reply other threads:[~2018-10-03 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:23 new mt76 usb crashes on device removal Stanislaw Gruszka
2018-10-03 9:15 ` Lorenzo Bianconi [this message]
2018-10-03 10:29 ` Stanislaw Gruszka
2018-10-03 10:32 ` Lorenzo Bianconi
2018-10-03 14:09 ` Lorenzo Bianconi
2018-10-03 14:23 ` Stanislaw Gruszka
2018-10-03 14:32 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003091536.GB27279@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox