* [PATCH] ssb: chipcommon: fix fall-through annotation
@ 2018-10-03 12:01 Gustavo A. R. Silva
2018-10-03 20:04 ` Michael Büsch
2018-10-05 8:37 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-03 12:01 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless, linux-kernel, Gustavo A. R. Silva
Replace "Fallthough" with a proper "fall through" annotation.
This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/ssb/driver_chipcommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
index 99a4656..3861cb6 100644
--- a/drivers/ssb/driver_chipcommon.c
+++ b/drivers/ssb/driver_chipcommon.c
@@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
break;
}
- /* Fallthough */
+ /* Fall through */
default:
*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: chipcommon: fix fall-through annotation
2018-10-03 12:01 [PATCH] ssb: chipcommon: fix fall-through annotation Gustavo A. R. Silva
@ 2018-10-03 20:04 ` Michael Büsch
2018-10-05 8:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2018-10-03 20:04 UTC (permalink / raw)
To: Gustavo A. R. Silva, Kalle Valo; +Cc: linux-wireless, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Wed, 3 Oct 2018 14:01:02 +0200
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Replace "Fallthough" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/ssb/driver_chipcommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
> index 99a4656..3861cb6 100644
> --- a/drivers/ssb/driver_chipcommon.c
> +++ b/drivers/ssb/driver_chipcommon.c
> @@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
> break;
> }
> - /* Fallthough */
> + /* Fall through */
> default:
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
> }
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: chipcommon: fix fall-through annotation
2018-10-03 12:01 [PATCH] ssb: chipcommon: fix fall-through annotation Gustavo A. R. Silva
2018-10-03 20:04 ` Michael Büsch
@ 2018-10-05 8:37 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-10-05 8:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Michael Buesch, linux-wireless, linux-kernel, Gustavo A. R. Silva
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Replace "Fallthough" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Michael Buesch <m@bues.ch>
Patch applied to wireless-drivers-next.git, thanks.
74aa3586c599 ssb: chipcommon: fix fall-through annotation
--
https://patchwork.kernel.org/patch/10624745/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-05 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-03 12:01 [PATCH] ssb: chipcommon: fix fall-through annotation Gustavo A. R. Silva
2018-10-03 20:04 ` Michael Büsch
2018-10-05 8:37 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).