From: "Michael Büsch" <m@bues.ch>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ssb: chipcommon: fix fall-through annotation
Date: Wed, 3 Oct 2018 22:04:35 +0200 [thread overview]
Message-ID: <20181003220435.6f7c27b4@wiggum> (raw)
In-Reply-To: <20181003120102.GA22824@embeddedor.com>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Wed, 3 Oct 2018 14:01:02 +0200
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Replace "Fallthough" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/ssb/driver_chipcommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
> index 99a4656..3861cb6 100644
> --- a/drivers/ssb/driver_chipcommon.c
> +++ b/drivers/ssb/driver_chipcommon.c
> @@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
> break;
> }
> - /* Fallthough */
> + /* Fall through */
> default:
> *m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
> }
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-03 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 12:01 [PATCH] ssb: chipcommon: fix fall-through annotation Gustavo A. R. Silva
2018-10-03 20:04 ` Michael Büsch [this message]
2018-10-05 8:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003220435.6f7c27b4@wiggum \
--to=m@bues.ch \
--cc=gustavo@embeddedor.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).