From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Tomislav Požega" <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Daniel Golle <daniel@makrotopia.org>,
Mathias Kresin <dev@kresin.me>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH 0/5] rt2800mmio txdone/interrupts/flush rework
Date: Fri, 5 Oct 2018 09:44:23 +0200 [thread overview]
Message-ID: <20181005074422.GA1931@redhat.com> (raw)
In-Reply-To: <1538697102-3764-1-git-send-email-pozega.tomislav@gmail.com>
(adding back removed CCs)
On Fri, Oct 05, 2018 at 01:51:42AM +0200, Tomislav Požega wrote:
> Hi
Hi.
> As suspected this changeset causes throughput regression.
You seems to have prejudice against my work :-)
> Below screenshots show iperf test from MS150N (RF5370) device connected to RT3070 adapter running AP mode:
>
> This is with standard openwrt build without any rt2x00 changes:
>
> [url=https://postimg.cc/BtYQLf6r][img]https://i.postimg.cc/BtYQLf6r/shot-2018-10-04_17-23-56.jpg[/img][/url]
>
> And this printscreen show iperf test with your changes:
>
> [url=https://postimg.cc/D8Sf1p48][img]https://i.postimg.cc/D8Sf1p48/shot-2018-10-04_17-42-09.jpg[/img][/url]
My experience is that performance between two rt2800 devices vary with
no apparent reason. There are two problems I know that maigh affect
performance at random (and I think there are also some other low level
problems that I'm not aware of that cause performance fluctuations).
First problem is that HW aggregate RATE_PROBE frames with other frames
at different rate, so we can not do rate probing properly for rate
control algorithm.
Second problem: we send BAR when we fail to send a frame and this might
have positive and negative effect, depend what remote hardware do when it
gets BAR. This seems to be problem when two rt2800 devices are connected
and not a problem if rt2800 is connected with ath or iwl devices.
> Atheros card connected to RT3070 iperf test difference was negligible (1Mbps or less) on bodhi system, but
> it started to throw out reorder messages on my standard ubuntu after your changes:
>
> [url=https://postimg.cc/SjJbP2SP][img]https://i.postimg.cc/SjJbP2SP/Screenshot.png[/img][/url]
Ok, thats seems not right, I will try to reproduce this.
> My advice: stop sending low-quality patches and do some testing before submission.
My advice: stop being arrogant if you want to work with others.
Patches were tested on USB devices. At first I thought they broke
rt2800usb support:
https://bugzilla.kernel.org/show_bug.cgi?id=82751#c17
but then when I wanted to debug that, they start to work;
https://bugzilla.kernel.org/show_bug.cgi?id=82751#c33
I assumed that previous breakage was caused by some different
change not related with those patches.
Anyway I would appreciate any additional testing of my rt2x00 patches
as well as code review, if anyone would like to do this.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-10-05 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 10:24 [PATCH 0/5] rt2800mmio txdone/interrupts/flush rework Stanislaw Gruszka
2018-09-26 10:24 ` [PATCH 1/5] rt2800: move usb specific txdone/txstatus routines to rt2800lib Stanislaw Gruszka
2018-10-01 15:39 ` Kalle Valo
2018-09-26 10:24 ` [PATCH 2/5] rt2800mmio: use txdone/txstatus routines from lib Stanislaw Gruszka
2018-09-26 10:24 ` [PATCH 3/5] rt2x00: do not check for txstatus timeout every time on tasklet Stanislaw Gruszka
2018-09-26 10:24 ` [PATCH 4/5] rt2x00: use different txstatus timeouts when flushing Stanislaw Gruszka
2018-09-26 10:24 ` [PATCH 5/5] rt2800: flush and txstatus rework for rt2800mmio Stanislaw Gruszka
2018-10-04 23:51 ` [PATCH 0/5] rt2800mmio txdone/interrupts/flush rework Tomislav Požega
2018-10-05 7:44 ` Stanislaw Gruszka [this message]
2018-10-05 10:03 ` Stanislaw Gruszka
2018-10-05 10:05 ` Felix Fietkau
2018-10-05 10:34 ` Stanislaw Gruszka
[not found] ` <DM5PR02MB3656089F61C0AD9C4D5E5FBCD4CA0@DM5PR02MB3656.namprd02.prod.outlook.com>
2018-11-05 12:10 ` Tom Psyborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005074422.GA1931@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).