linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] b43: remove set but not used variable 'wl'
@ 2018-10-05  4:15 YueHaibing
  2018-10-05  8:38 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-10-05  4:15 UTC (permalink / raw)
  To: Kalle Valo, Colin Ian King
  Cc: YueHaibing, linux-wireless, b43-dev, kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
 variable 'wl' set but not used [-Wunused-but-set-variable]
 
After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
'wl' is not used any more.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/wireless/broadcom/b43/main.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 4daa1ce..74be3c8 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -5493,13 +5493,11 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
 static void b43_one_core_detach(struct b43_bus_dev *dev)
 {
 	struct b43_wldev *wldev;
-	struct b43_wl *wl;
 
 	/* Do not cancel ieee80211-workqueue based work here.
 	 * See comment in b43_remove(). */
 
 	wldev = b43_bus_get_wldev(dev);
-	wl = wldev->wl;
 	b43_debugfs_remove_device(wldev);
 	b43_wireless_core_detach(wldev);
 	list_del(&wldev->list);


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] b43: remove set but not used variable 'wl'
  2018-10-05  4:15 [PATCH] b43: remove set but not used variable 'wl' YueHaibing
@ 2018-10-05  8:38 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-10-05  8:38 UTC (permalink / raw)
  To: YueHaibing
  Cc: Colin Ian King, YueHaibing, linux-wireless, b43-dev,
	kernel-janitors

YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/broadcom/b43/main.c: In function 'b43_one_core_detach':
> drivers/net/wireless/broadcom/b43/main.c:5496:17: warning:
>  variable 'wl' set but not used [-Wunused-but-set-variable]
>  
> After commit 644aa4d62096 ("b43: remove list of IEEE 802.11 devices")
> 'wl' is not used any more.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

a7dd5d7c2dd8 b43: remove set but not used variable 'wl'

-- 
https://patchwork.kernel.org/patch/10627361/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-05  8:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-05  4:15 [PATCH] b43: remove set but not used variable 'wl' YueHaibing
2018-10-05  8:38 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).