From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
Subject: [PATCH v2 02/13] qtnfmac: generate local disconnect event in disconnect callback
Date: Fri, 5 Oct 2018 10:11:28 +0000 [thread overview]
Message-ID: <20181005101114.3013-3-sergey.matyukevich.os@quantenna.com> (raw)
In-Reply-To: <20181005101114.3013-1-sergey.matyukevich.os@quantenna.com>
From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
When cfg80211 disconnect callback is triggered and command is
processed by firmware, disconnect event with local parameter
set must be sent immediately. Indicating that it's a "local"
event (not from AP) will help upper layers to process this
event correctly.
Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index 776cfba7396e..87f48b7fb673 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -660,10 +660,14 @@ qtnf_disconnect(struct wiphy *wiphy, struct net_device *dev,
qtnf_scan_done(mac, true);
ret = qtnf_cmd_send_disconnect(vif, reason_code);
- if (ret) {
+ if (ret)
pr_err("VIF%u.%u: failed to disconnect\n", mac->macid,
vif->vifid);
- goto out;
+
+ if (vif->wdev.current_bss) {
+ netif_carrier_off(vif->netdev);
+ cfg80211_disconnected(vif->netdev, reason_code,
+ NULL, 0, true, GFP_KERNEL);
}
out:
@@ -1140,12 +1144,9 @@ void qtnf_virtual_intf_cleanup(struct net_device *ndev)
struct qtnf_vif *vif = qtnf_netdev_get_priv(ndev);
struct qtnf_wmac *mac = wiphy_priv(vif->wdev.wiphy);
- if (vif->wdev.iftype == NL80211_IFTYPE_STATION) {
- cfg80211_disconnected(vif->netdev, WLAN_REASON_DEAUTH_LEAVING,
- NULL, 0, 1, GFP_KERNEL);
+ if (vif->wdev.iftype == NL80211_IFTYPE_STATION)
qtnf_disconnect(vif->wdev.wiphy, ndev,
WLAN_REASON_DEAUTH_LEAVING);
- }
qtnf_scan_done(mac, true);
}
--
2.11.0
next prev parent reply other threads:[~2018-10-05 10:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 10:11 [PATCH v2 00/13] qtnfmac: fixes and cleanups for STA mode Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 01/13] qtnfmac: do not track STA states in driver Sergey Matyukevich
2018-10-05 11:04 ` Kalle Valo
2018-10-05 10:11 ` Sergey Matyukevich [this message]
2018-10-05 10:11 ` [PATCH v2 03/13] qtnfmac: request userspace to do OBSS scanning if FW can not Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 04/13] qtnfmac: do not initialize per-MAC data multiple times Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 05/13] qtnfmac: cleanup and unify command error handling Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 06/13] qtnfmac: do not cancel scan in disconnect callback Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 07/13] qtnfmac: pass sgi rate info flag to wireless core Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 08/13] qtnfmac: inform wireless core about supported extended capabilities Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 09/13] qtnfmac: drop error reports for out-of-bounds key indexes Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 10/13] qtnfmac: add support for scan flush Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 11/13] qtnfmac: add support for scan dwell time configuration Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 12/13] qtnfmac: drop redundant data copy in control path Sergey Matyukevich
2018-10-05 10:11 ` [PATCH v2 13/13] qtnfmac: implement dump_station support for STA mode Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005101114.3013-3-sergey.matyukevich.os@quantenna.com \
--to=sergey.matyukevich.os@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).