From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Tony Chuang <yhchuang@realtek.com>,
"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC v2 04/12] rtw88: trx files
Date: Mon, 8 Oct 2018 11:19:16 +0200 [thread overview]
Message-ID: <20181008091915.GC1961@redhat.com> (raw)
In-Reply-To: <878t3bfe7o.fsf@kamboji.qca.qualcomm.com>
On Sat, Oct 06, 2018 at 03:32:11PM +0300, Kalle Valo wrote:
> Tony Chuang <yhchuang@realtek.com> writes:
>
> >> > + pkt_info->bmc = bmc;
> >> > + pkt_info->sec_type = sec_type;
> >> > + pkt_info->tx_pkt_size = skb->len;
> >> > + pkt_info->offset = chip->tx_pkt_desc_sz;
> >> > + pkt_info->qsel = skb->priority;
> >>
> >> Shouldn't be qsel somehow mapped from skb->priority ?
> >
> > Firmware handles it.
>
> What if meaning of skb->priority changes in the future? I don't think
> it's safe to provide kernel internal values to firmware, you should do
> some kind of mapping in the driver.
We already have some functions that do mapping:
rtw_hw_queue_mapping(struct sk_buff *skb)
and
rtw_pci_get_tx_qsel(struct sk_buff *skb, u8 queue)
Preasumly they should be used here as well.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-10-08 9:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:02 [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2018-10-03 8:02 ` [RFC v2 01/12] rtw88: main files yhchuang
2018-10-03 8:02 ` [RFC v2 02/12] rtw88: core files yhchuang
2018-10-04 11:42 ` Stanislaw Gruszka
2018-10-04 13:52 ` Stanislaw Gruszka
2018-10-08 8:22 ` Tony Chuang
2018-10-03 8:02 ` [RFC v2 03/12] rtw88: hci files yhchuang
2018-10-04 13:02 ` Stanislaw Gruszka
2018-10-04 13:25 ` Stanislaw Gruszka
2018-10-05 12:07 ` Tony Chuang
2018-10-06 12:29 ` Kalle Valo
2018-10-08 9:03 ` Tony Chuang
2018-10-08 9:34 ` Stanislaw Gruszka
2019-03-25 14:33 ` Brian Norris
2018-10-03 8:02 ` [RFC v2 04/12] rtw88: trx files yhchuang
2018-10-04 13:19 ` Stanislaw Gruszka
2018-10-05 9:20 ` Tony Chuang
2018-10-06 12:32 ` Kalle Valo
2018-10-08 9:19 ` Stanislaw Gruszka [this message]
2018-10-08 9:35 ` Tony Chuang
2018-10-08 9:25 ` Stanislaw Gruszka
2018-10-03 8:02 ` [RFC v2 05/12] rtw88: mac files yhchuang
2018-10-03 8:02 ` [RFC v2 06/12] rtw88: fw and efuse files yhchuang
2018-10-04 10:49 ` Stanislaw Gruszka
2018-10-05 9:19 ` Tony Chuang
2018-10-08 9:15 ` Stanislaw Gruszka
2018-10-06 12:34 ` Kalle Valo
2018-10-03 8:02 ` [RFC v2 07/12] rtw88: phy files yhchuang
2018-10-03 8:02 ` [RFC v2 08/12] rtw88: debug files yhchuang
2018-10-03 8:02 ` [RFC v2 09/12] rtw88: chip files yhchuang
2018-10-03 8:02 ` [RFC v2 10/12] rtw88: 8822B init table yhchuang
2018-10-03 8:02 ` [RFC v2 11/12] rtw88: 8822C " yhchuang
2018-10-03 8:02 ` [RFC v2 12/12] rtw88: Kconfig & Makefile yhchuang
2018-10-03 16:15 ` [RFC v2 00/12] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Sid Hayn
2018-10-03 16:52 ` Larry Finger
2018-10-03 16:57 ` Sid Hayn
2018-10-03 17:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008091915.GC1961@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).