From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
Date: Tue, 9 Oct 2018 10:48:21 +0200 [thread overview]
Message-ID: <20181009084820.GA16331@localhost.localdomain> (raw)
In-Reply-To: <a0683f63-31d6-5cd7-b375-e45d1815e0c7@nbd.name>
> > I think is needed we do:
> >
> > reg_val = mt76_rr(dev, 0x2124);
> > mt76_wr(dev, 0x2124, 0xffffff7e);
> >
> > CALIBRATE
> >
> > mt76_wr(dev, 0x2124, reg_val);
> >
> > so seems we have to restore orginal value after calibration.
> >
> > Referencing as MT_BBP(IBI, 9) is obviously fine.
> Yes, that makes more sense.
>
> - Felix
Ack, I will send v2 with proper register name.
Regards,
Lorenzo
prev parent reply other threads:[~2018-10-09 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1539001391.git.lorenzo.bianconi@redhat.com>
2018-10-08 12:40 ` [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc Lorenzo Bianconi
2018-10-08 18:11 ` Felix Fietkau
2018-10-08 19:55 ` Lorenzo Bianconi
2018-10-09 7:35 ` Stanislaw Gruszka
2018-10-09 8:35 ` Felix Fietkau
2018-10-09 8:48 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009084820.GA16331@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).