From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mt76x0: phy: fix mt76x0_temp_sensor routine
Date: Wed, 10 Oct 2018 12:09:07 +0200 [thread overview]
Message-ID: <20181010100907.GB3371@localhost.localdomain> (raw)
In-Reply-To: <20181010095642.GB2856@redhat.com>
> > static void mt76x0_dynamic_vga_tuning(struct mt76x02_dev *dev)
> > @@ -832,7 +825,11 @@ static void mt76x0_phy_calibrate(struct work_struct *work)
> > cal_work.work);
> >
> > mt76x0_dynamic_vga_tuning(dev);
> > - mt76x0_temp_sensor(dev);
> > + if (!mt76x0_tssi_enabled(dev)) {
> > + int temp;
> > +
> > + mt76x0_temp_sensor(dev, &temp);
>
> Why this &temp is needed ? Preasumble it will be used in the future,
> but maybe you could at least add dev_dbg() to print it's value?
Correct. Sure I can add it in v2.
Regards,
Lorenzo
>
> Thanks
> Stanislaw
prev parent reply other threads:[~2018-10-10 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 9:14 [PATCH 0/2] fix temperature compensation for mt76x0 Lorenzo Bianconi
2018-10-10 9:14 ` [PATCH 1/2] mt76x0: eeprom: introduce mt76x0_tssi_enabled routine Lorenzo Bianconi
2018-10-10 9:14 ` [PATCH 2/2] mt76x0: phy: fix mt76x0_temp_sensor routine Lorenzo Bianconi
2018-10-10 9:56 ` Stanislaw Gruszka
2018-10-10 10:09 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010100907.GB3371@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox