From: Daniel Golle <daniel@makrotopia.org>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
linux-wireless@vger.kernel.org, Mathias Kresin <dev@kresin.me>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH 4/4] rt2800: comment and simplify AGC init for RT6352
Date: Wed, 10 Oct 2018 22:11:51 +0200 [thread overview]
Message-ID: <20181010201149.GA17530@makrotopia.org> (raw)
In-Reply-To: <CAKR_QVJfQuFee4P-cnp_7bKGmoUTTxnkCfXoovqsGxs72+gCLg@mail.gmail.com>
On Wed, Oct 10, 2018 at 10:09:14PM +0200, Tom Psyborg wrote:
> it's 6352 dude
true. thanks for the review!
>
> On 10/10/2018, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > We do not need separate lines for calculating register values.
> > Also add comment that value is different than in vendor driver.
> >
> > Suggested-by: Daniel Golle <daniel@makrotopia.org>
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > index a2cdd3a5034a..7b6effaa0740 100644
> > --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> > @@ -3986,9 +3986,12 @@ static void rt2800_config_channel(struct rt2x00_dev
> > *rt2x00dev,
> > rt2800_bbp_write(rt2x00dev, 195, 141);
> > rt2800_bbp_write(rt2x00dev, 196, reg);
> >
> > - /* AGC init */
> > - reg = rf->channel <= 14 ? 0x1c : 0x24;
> > - reg += 2 * rt2x00dev->lna_gain;
> > + /* AGC init.
> > + * Despite the vendor driver using different values here for
> > + * RT6362 chip, we use 0x1c for now. This may have to be changed
> > + * once TSSI got implemented.
> > + */
> > + reg = (rf->channel <= 14 ? 0x1c : 0x24) + 2*rt2x00dev->lna_gain;
> > rt2800_bbp_write_with_rx_chain(rt2x00dev, 66, reg);
> >
> > rt2800_iq_calibrate(rt2x00dev, rf->channel);
> > --
> > 2.7.5
> >
> >
next prev parent reply other threads:[~2018-10-10 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 15:46 [PATCH 0/4] rt2800: more register programing tweaks Stanislaw Gruszka
2018-10-10 15:46 ` [PATCH 1/4] rt2800: enable TX_PIN_CFG_LNA_PE_ bits per band Stanislaw Gruszka
2018-10-10 15:46 ` [PATCH 2/4] rt2800: enable TX_PIN_CFG_RFRX_EN only for MT7620 Stanislaw Gruszka
2018-10-10 15:46 ` [PATCH 3/4] rt2800: remove unneeded RT6352 check Stanislaw Gruszka
2018-10-10 15:46 ` [PATCH 4/4] rt2800: comment and simplify AGC init for RT6352 Stanislaw Gruszka
2018-10-10 20:09 ` Tom Psyborg
2018-10-10 20:11 ` Daniel Golle [this message]
2018-10-11 10:07 ` [PATCH 0/4] rt2800: more register programing tweaks Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010201149.GA17530@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).