From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: usb: fix static tracepoints
Date: Thu, 18 Oct 2018 10:13:51 +0200 [thread overview]
Message-ID: <20181018081350.GA4938@localhost.localdomain> (raw)
In-Reply-To: <20181018064521.GA2199@redhat.com>
On Oct 18, Stanislaw Gruszka wrote:
> On Thu, Oct 18, 2018 at 12:35:32AM +0200, Lorenzo Bianconi wrote:
> > Add submit_urb and rx_urb static tracepoints in mt76-usb module.
> > Move trace_mac_txstat_fetch in mt76x02_mac_load_tx_status routine
> > in order to be available to usb drivers. Moreover remove
> > no longer used mt76x0/trace.{c,h}
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > ---
> > @@ -54,7 +53,7 @@ mt76x0_rf_csr_wr(struct mt76x02_dev *dev, u32 offset, u8 value)
> > FIELD_PREP(MT_RF_CSR_CFG_REG_ID, reg) |
> > MT_RF_CSR_CFG_WR |
> > MT_RF_CSR_CFG_KICK);
> > - trace_mt76x0_rf_write(&dev->mt76, bank, offset, value);
>
> I think tracing RF registers writes/read can still be useful.
Hi Stanislaw,
I removed tracing for RF registers since these operations are already tracked in
mt76_wr/mt76_rr so I thought they were redundant. Do you think deducing rf
read/write operations from mt76_{rr,wr} tracing is too convoluted? If so I
can reintroduce them in v2.
Regards,
Lorenzo
>
> Thanks
> Stanislaw
next prev parent reply other threads:[~2018-10-18 8:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1539815635.git.lorenzo.bianconi@redhat.com>
2018-10-17 22:35 ` [PATCH] mt76: usb: fix static tracepoints Lorenzo Bianconi
2018-10-18 6:45 ` Stanislaw Gruszka
2018-10-18 8:13 ` Lorenzo Bianconi [this message]
2018-10-18 8:17 ` Stanislaw Gruszka
2018-10-18 14:19 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018081350.GA4938@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).