From: Lars Poeschel <poeschel@lemonage.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Jiri Slaby <jslaby@suse.com>, Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] nfc: pn533: add UART phy driver
Date: Thu, 18 Oct 2018 15:03:46 +0200 [thread overview]
Message-ID: <20181018130346.GA3975@lem-wkst-02.lemonage> (raw)
In-Reply-To: <20181017115357.GC32302@kroah.com>
On Wed, Oct 17, 2018 at 01:53:57PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 17, 2018 at 12:20:35PM +0200, Lars Poeschel wrote:
> > This adds the UART phy interface for the pn533 driver.
> > The pn533 driver can be used through UART interface this way.
> > It is implemented as a tty line discipline.
>
> Why not use the serdev interface instead?
Maybe because the most obivious is not obivious enough. ;)
I did not know about serdev before. Thank you very much for this! I am
almost finished migrating to serdev and everything is much cleaner and
more simple now!
I will post a follow-up with all your other comments addressed.
Thanks,
Lars
next prev parent reply other threads:[~2018-10-18 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:20 [PATCH 1/3] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-17 10:20 ` [PATCH 2/3] nfc: pn533: Add autopoll capability Lars Poeschel
2018-10-17 10:20 ` [PATCH 3/3] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel
2018-10-17 11:53 ` [PATCH 1/3] nfc: pn533: add UART phy driver Greg Kroah-Hartman
2018-10-18 13:03 ` Lars Poeschel [this message]
2018-10-17 11:56 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018130346.GA3975@lem-wkst-02.lemonage \
--to=poeschel@lemonage.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox