From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH 1/2] mt76: mt76x0: reduce duplication in setting rf bandwidth parameters
Date: Fri, 19 Oct 2018 10:17:58 +0200 [thread overview]
Message-ID: <20181019081757.GA17167@redhat.com> (raw)
In-Reply-To: <20181018141645.31484-1-nbd@nbd.name>
On Thu, Oct 18, 2018 at 04:16:44PM +0200, Felix Fietkau wrote:
> Remove initval table with duplicated registers and driver specific flags
> in favor of a function that sets the registers directly
There are few problems with this patch: MT_RF(7, 77) is missing and
band is not taken directly from chandef but overwriteen in
'rf_band = mt76x0_frequency_plan[i].band' . But even after fixing that
I can not make MT7610U associate with AP on 5GHz. So please drop this
patch.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-10-19 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:16 [PATCH 1/2] mt76: mt76x0: reduce duplication in setting rf bandwidth parameters Felix Fietkau
2018-10-18 14:16 ` [PATCH 2/2] mt76: mt76x0: handle chip specific initval differences Felix Fietkau
2018-10-19 8:17 ` Stanislaw Gruszka [this message]
2018-10-19 8:55 ` [PATCH 1/2] mt76: mt76x0: reduce duplication in setting rf bandwidth parameters Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019081757.GA17167@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox